Conversation
- in-process must clear the limit on upgrade because its read loop enforces it - out-of-process runs on Kestrel, which never enforces it once upgraded - unblocks the three WebSocketsOutOfProcessTests failures 🧪 - Generated by Copilot (cherry picked from commit befb2e9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe
requested review from
BrennanConroy,
JamesNK and
halter73
as code owners
September 15, 2026 17:10
Contributor
|
Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The hosting-specific assertion change has no unresolved review issues.
Pull request overview
Scopes the WebSocket request-body assertion to IIS in-process hosting, preventing premature closure in out-of-process tests.
Changes:
- Detects in-process hosting via
IServerVariablesFeature. - Retains the assertion only for in-process requests.
File summaries
| File | Description |
|---|---|
src/Servers/IIS/IIS/test/testassets/InProcessWebSite/Startup.WebSockets.cs |
Limits the request-body assertion to in-process hosting. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
wtgodbe
added
the
tell-mode
BrennanConroy
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of befb2e9.
The shared IIS WebSocket test application asserted that
IHttpMaxRequestBodySizeFeature.MaxRequestBodySizewas cleared after upgrading for both hosting models. In-process hosting requires that behavior because its read loop enforces the limit, but out-of-process hosting runs on Kestrel, which does not enforce the limit after upgrade.Scope the assertion to in-process hosting so the following out-of-process tests do not close the WebSocket prematurely:
OnStartedCalledForWebSocketCanSendAndReceieveDataWebReadBeforeUpgradeThe same fix was applied directly to #69256 and #69301.