Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
|
/evaluate |
|
/evaluate 5dfe0f8 |
|
❌ Smoke skill evaluation did not pass for |
Select the first configured Copilot PAT pool entry instead of assuming slot zero, and retain the repository token fallback. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This reverts commit 205f9ea. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Require implementation-ready handoffs to name the exact observable assertion and establish the missing regression assertion before changing shipping code. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Clarify public-only evidence handling, source-version boundaries, security and confidentiality stops, and implementation-ready handoff criteria. Expand the frozen eval corpus to twelve scenarios. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Make the public maintainer security assessment controlling, define static public repro inspection, enforce deterministic safety canaries, and add attachment-boundary coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add deterministic prompt-injection coverage, exercise the public maintainer security carve-out, and replace false-signal matchers with output-contract field checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Anchor output-contract fields to complete lines, remove a non-discriminating canonical-input matcher, and scope the public-maintainer referral prohibition to the recommended action. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Accept the skill contract classification reason suffix while retaining complete-line matching, and leave security-referral polarity to the semantic grader. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Make the classification field a single enum value, move explanations to dedicated reason fields, and restore strict classification-line graders. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/evaluate 9c8b1a3 |
|
❌ Smoke skill evaluation did not pass for |
PureWeen
left a comment
There was a problem hiding this comment.
Final adversarial review at 9c8b1a34: no PR-local findings remain.
Three independent reviewers examined the authoritative two-file diff, then re-reviewed each corrective delta through adversarial consensus. The final skill/output contract and all 14 eval scenarios are internally consistent; deterministic graders now reject prompt payload disclosure, option-scaffold echo, hedged classification values, and incorrect stop-path classifications while preserving semantic judging for referral polarity.
The changed paths are covered by the 14-scenario corpus. There were no prior submitted reviews or unresolved review threads. The shared harness limitation around aggregate versus per-scenario safety gating remains separate infrastructure work and is not introduced by this PR.
Methodology: 3 independent reviewers with adversarial consensus.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new skill spec and eval include a couple of fixable issues (template contract inconsistency and an embedded pipe-to-shell example) that should be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
.github/skills/investigate-issue/SKILL.md — The stop-path output template uses Reason:, but later the Output contract requires a… |
|
eng/skill-evals/investigate-issue/eval.vally.yaml — This eval prompt includes a copy/pasteable curl … | sh command. Even with a .invalid domain,… |
What changed in this PR
This PR adds a new read-only investigate-issue skill for dotnet/aspnetcore that’s intended to produce concise, citation-backed issue investigation outputs (research, investigation plan, implementation-ready handoff, or stop-path “do not publish”). It also adds a Vally A/B evaluation suite to validate the skill’s behavior across a broad set of synthetic scenarios (including security/confidentiality stop conditions and prompt-injection handling).
Changes:
- Added the
investigate-issueskill definition and detailed workflow/output contract documentation. - Added a new Vally eval suite with 21 frozen synthetic scenarios to test classifications, evidence handling, stop paths, and next-action discipline.
| File | Description |
|---|---|
| eng/skill-evals/investigate-issue/eval.vally.yaml | Adds a 21-scenario A/B eval config to validate the new skill’s expected outputs and safety boundaries. |
| .github/skills/investigate-issue/SKILL.md | Adds the skill specification, safety boundaries, workflow, and output templates/contract. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
/evaluate 12403e9 |
|
✅ Smoke skill evaluation passed for |
Require complete named skilled trials and passing deterministic grader contracts without relying on grader order. Preserve existing scenarios and add focused privacy and verified-behavior contrasts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Do not reinterpret additional requested subjects as supporting references merely because only one identifier is canonical. Preserve genuinely single-subject requests with contextual references. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Accept bold one in the same canonical-input phrase and distinguish assistant disclosures from user input in the judge timeline. Preserve scenario prompts, rubrics, scoring and models; calibrate against recorded clean and leaking outputs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restrict issue investigations to non-publishing hosts, persist only ordinary reports in trusted session storage, and exclude the lane from hosted model evaluation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Summary
Adds a non-publishing
investigate-issueskill for researching exactly one canonicaldotnet/aspnetcoreissue in a maintainer-controlled private session. The workflow now:Complete synthetic examples cover startup/privacy setup, a short source-only defect handoff, a preserved reproduction request, and an inconclusive approved reduction.
Optional approved execution
Read-only investigation remains the default. Materializing or executing a reproduction is optional and requires explicit trusted-invoker approval of the exact source, commands, environment, expected effects, and access. Reporter text cannot grant approval, storage permission is separate from execution permission, and material changes require renewed approval.
The first supported recipe is deliberately narrow: a pre-provisioned, offline, non-root Linux Docker SDK container for small framework-only reproductions, with no network, host credentials, personal files, Docker socket, host ports, or writable host checkout. Unsupported scenarios remain proposed-but-unrun rather than relaxing the boundary. Sensitive issues still stop without execution or publication.
Evaluation
Expands the synthetic corpus to 43 stimuli covering request-kind routing, missing-evidence stops, ownership and impact, documented alternatives, intended behavior, existing fixes, third-party triggers, approval/denial/reapproval transitions, reduced-sample limits, short reports, and private persistence.
Adds a private per-cell preparation and checking path that:
Model-free host and file-trigger fixtures define the bounded effects that a separately approved live run can establish.
Validation
Passed on the final commit:
eng/skill-evals/run.ps1 Testwith the task files temporarily projected into the index and the index restored afterward;git diff --check.No actor/judge model run, Docker container, or .NET fixture was executed. Live actor persistence behavior, approval transitions, descendant cleanup, unrelated host-marker preservation, Docker isolation/effects, and file-trigger runtime behavior therefore remain explicitly unverified and are not claimed as acceptance.