Enable CONFIG_FEATURE_EDITING_VI (set -o vi) - #249
Open
evan314159 wants to merge 1 commit into
Open
evan314159 wants to merge 1 commit into
evan314159 wants to merge 1 commit into
Conversation
The default is not to include vi editing but it is commonly included in distributions (e.g. Alpine) and is a big quality of life improvement for those used to vi keys. On my build (amd64) size(1) grows by +2k but the overall busybox executable size is unchanged due to being absorbed in padding.
Member
|
In general we try very hard to keep our explicit configuration minimal / as close to the upstream defaults as possible, so while I think this is a neat feature, I'm leaning towards nack on including it. 🙇 |
Author
|
I surveyed major distributions. vi mode is enabled on: Alpine, Fedora, CentOS Stream (via EPEL), Arch, Void, Buildroot, so it is broadly baked into popular distributions, with Debian and Ubuntu being notable exceptions, enough that it is not exactly a personal preference. In my case I thought I was doing something wrong that it was not available, as set -o vi does not return an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default is not to include vi editing but it is commonly included in distributions (e.g. Alpine) and is a big quality of life improvement for those used to vi keys. On my build (amd64) size(1) grows by +2k but the overall busybox executable size is unchanged due to being absorbed in padding.