Conversation
Add a table that documents the resulting connection scheme, default port, and TLS mode for every combination of the startTLS and insecureNoSSL flags. Also add warning callouts about the two common misconfigurations: using insecureNoSSL + startTLS, and using startTLS with the implicit-TLS default port 636. Fixes dexidp/dex#2351 Signed-off-by: Sakthi Harish <sakthi.harish@edgeverve.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change documents the TLS behavior of the LDAP connector so users can see which scheme, default port, and TLS mode result from every combination of the
startTLSandinsecureNoSSLflags.What changed:
startTLS/insecureNoSSL.insecureNoSSL: truetakes precedence overstartTLS: true, producing a plaintext connection instead of StartTLS.startTLSand implicit TLS (ldaps://) cannot be combined; withstartTLS: truethe connector always usesldap://.hostcomment in the example config to match the actual default-port logic.Fixes dexidp/dex#2351