fix: stop one slow device from blocking the others - #1246
Open
amarnath-ac wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
=======================================
Coverage 56.71% 56.71%
=======================================
Files 149 149
Lines 12154 12154
=======================================
Hits 6893 6893
Misses 5260 5260
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
amarnath-ac
force-pushed
the
fix_slow_device_blocks_others
branch
from
September 4, 2026 09:21
f15e35a to
6b2ad42
Compare
The worker ran each connection setup inline, so one stuck device held the only goroutine and the rest queued behind it.
amarnath-ac
marked this pull request as ready for review
September 4, 2026 09:29
amarnath-ac
requested review from
DevipriyaS17,
madhavilosetty-intel and
rsdmike
September 4, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker ran each connection setup inline, so one stuck device held the only goroutine and the rest queued behind it.
Steps to reproduce:
Behavior:
Before:
Opening one device's details while another device was still loading (or was unreachable) left the second device stuck. Its calls sat behind the first one and either returned very late or timed out with 504. Every device shared a single goroutine, so one bad device slowed all of them.
After fix:
Each device's connection setup runs on its own goroutine. An unreachable device still fails on its own, but other devices load normally at the same time.