Skip to content

fix: stop one slow device from blocking the others - #1246

Open
amarnath-ac wants to merge 1 commit into
mainfrom
fix_slow_device_blocks_others
Open

fix: stop one slow device from blocking the others#1246
amarnath-ac wants to merge 1 commit into
mainfrom
fix_slow_device_blocks_others

Conversation

@amarnath-ac

@amarnath-ac amarnath-ac commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

The worker ran each connection setup inline, so one stuck device held the only goroutine and the rest queued behind it.

Steps to reproduce:

  1. Set disable_cira: true and start Console.
  2. Add a real vPro device that works.
  3. Add a dummy device with an unreachable IP (any IP on your subnet with no AMT).
  4. Open the dummy device's details page. Leave it loading.
  5. Go back to the device list and open the real device's details.

Behavior:
Before:
Opening one device's details while another device was still loading (or was unreachable) left the second device stuck. Its calls sat behind the first one and either returned very late or timed out with 504. Every device shared a single goroutine, so one bad device slowed all of them.

After fix:
Each device's connection setup runs on its own goroutine. An unreachable device still fails on its own, but other devices load normally at the same time.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.71%. Comparing base (df8cdd6) to head (6b2ad42).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1246   +/-   ##
=======================================
  Coverage   56.71%   56.71%           
=======================================
  Files         149      149           
  Lines       12154    12154           
=======================================
  Hits         6893     6893           
  Misses       5260     5260           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amarnath-ac
amarnath-ac force-pushed the fix_slow_device_blocks_others branch from f15e35a to 6b2ad42 Compare September 4, 2026 09:21
The worker ran each connection setup inline, so one stuck device
held the only goroutine and the rest queued behind it.
@amarnath-ac
amarnath-ac marked this pull request as ready for review September 4, 2026 09:29
@amarnath-ac
amarnath-ac requested a review from a team as a code owner September 4, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant