fix(inspect): drop @valibot/to-json-schema runtime dependency - #200
Merged
Conversation
The inspect plugin depended on @valibot/to-json-schema, which peer-depends on valibot without inspect declaring it — yielding an unmet-peer warning under Yarn (and violating devframe's validator-neutral policy, since the plugin shipped a preference for one schema library). Schema introspection now relies solely on each schema's own Standard JSON Schema converter (~standard.jsonSchema, e.g. zod 4) and degrades to a permissive object schema otherwise, mirroring the pattern already used by devframe's own MCP adapter (packages/devframe/src/adapters/mcp/to-json-schema.ts). Fixes #188 Fixed with the help of an agent.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
antfu
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@devframes/plugin-inspectdepended on@valibot/to-json-schema, whichpeer-depends on
valibot— a dependency the plugin never declared. Thatmismatch produces an unmet-peer warning under Yarn:
Beyond the warning, shipping
@valibot/to-json-schemaalso broke devframe'sstated validator-neutral policy: it gave the inspect plugin a preferred
schema library, when
devframe/@devframes/*packages should stay neutral.Fix
Schema introspection in the inspector now relies solely on each schema's own
Standard JSON Schema converter
(
~standard.jsonSchema, implemented by e.g. zod 4) and degrades to apermissive object schema for validators without one (e.g. valibot) — the
same vendor-neutral pattern devframe's own MCP adapter already uses
(
packages/devframe/src/adapters/mcp/to-json-schema.ts). This drops the@valibot/to-json-schemadependency (and itsvalibotpeer requirement)from
plugins/inspectentirely, so no dependency avoids or replaces it —it's simply no longer needed.
Fixes #188
Created with the help of an agent.