Skip to content

add tasks for run-to-completion work - #83

Open
atkrad wants to merge 2 commits into
mainfrom
add-tasks
Open

add tasks for run-to-completion work#83
atkrad wants to merge 2 commits into
mainfrom
add-tasks

Conversation

@atkrad

@atkrad atkrad commented Aug 16, 2026

Copy link
Copy Markdown
Member

Run-to-completion work lives under tasks: next to components. Not role: job.

Hook tasks (preDeploy / postDeploy) are Helm hook Jobs. Manual tasks run with deployah run. after orders hooks. fanout runs Indexed copies. deployah delete cleans leftover Jobs.

Bumps the spec to v1-alpha.5. CronJob / on: schedule stays #35.

Fixes #17.

@atkrad
add tasks for run-to-completion work
7170275 
- put jobs under tasks next to components
- add deployah run and leftover job cleanup
- bump the spec to v1-alpha.5
@github-actions github-actions Bot added kind/docs Documentation only area/cli Commands, flags, UX copy area/spec deployah.yaml schema or loading area/helm Chart render, release, post-render area/deploy Deploy and plan session flow area/testing Scenarios, harness, goldens labels Aug 16, 2026
@atkrad atkrad added kind/feature New capability and removed kind/docs Documentation only labels Aug 16, 2026
@atkrad atkrad self-assigned this Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.90018% with 66 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/cmd/run/run.go 88.57% 12 Missing ⚠️
internal/cmd/delete/delete.go 88.23% 10 Missing ⚠️
internal/helm/task.go 90.29% 10 Missing ⚠️
internal/plan/format_text.go 85.36% 6 Missing ⚠️
internal/testing/types.go 66.66% 4 Missing ⚠️
internal/cmd/logs/logs.go 70.00% 3 Missing ⚠️
internal/helm/generate.go 87.50% 3 Missing ⚠️
internal/spec/resolve.go 95.71% 3 Missing ⚠️
internal/cmd/deploy/deploy.go 75.00% 2 Missing ⚠️
internal/cmd/validate/validate.go 0.00% 2 Missing ⚠️
... and 6 more

📢 Thoughts on this report? Let us know!

@atkrad
cover task, delete, and run test gaps
7730420 
- cover delete preview parsing and dry-run output
- cover run and logs flag checks and job wait failures
- cover task validation, resolve, and helm chart values
@github-actions github-actions Bot added the kind/docs Documentation only label Aug 16, 2026
@atkrad atkrad removed the kind/docs Documentation only label Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@atkrad atkrad

Labels

area/cli Commands, flags, UX copy area/deploy Deploy and plan session flow area/helm Chart render, release, post-render area/spec deployah.yaml schema or loading area/testing Scenarios, harness, goldens kind/feature New capability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tasks: run-to-completion work (replaces role: job)

1 participant

@atkrad