Skip to content

harden helm pending checks and CRD coverage - #82

Merged
atkrad merged 1 commit into
mainfrom
harden-helm-pending-and-crd-coverage
Aug 11, 2026
Merged

harden helm pending checks and CRD coverage#82
atkrad merged 1 commit into
mainfrom
harden-helm-pending-and-crd-coverage

Conversation

@atkrad

@atkrad atkrad commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Reject stuck pending Helm releases with a typed Status.IsPending check before chart prep, instead of fragile string matching in wrapHelmError.
  • Add CRD lifecycle e2e coverage, chart-cache key invariant tests, and install-after-CRD-step unit coverage; consolidate Session client cloning.
  • Document CRD non-atomic failure modes and tighten the comparison note about where the Helm abstraction thins.

Test plan

  • Unit tests added/updated (internal/helm, internal/cmd/deploy, internal/session)
  • Scenario under scenarios/ (if behavior changes)
  • golangci-lint / pre-commit clean on commit
  • Manual smoke (command + expected result), if user-facing
  • E2E Kind suite (go test -tags=e2e ./internal/e2e/) for TestCRDLifecycle

Labels

  • One of: kind/feature, kind/bug, kind/docs, kind/chorekind/bug
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs updated (docs/comparison.md, docs/custom-manifests-and-crds.md)
  • No secrets or local-only paths in the diff

- reject pending releases with typed Status.IsPending before chart prep
- add CRD lifecycle e2e plus chart-cache and install-order unit tests
- document CRD failure modes and tighten the Helm abstraction note
@github-actions github-actions Bot added kind/docs Documentation only area/cli Commands, flags, UX copy area/helm Chart render, release, post-render area/deploy Deploy and plan session flow labels Aug 11, 2026
@atkrad atkrad added kind/bug Something is broken and removed kind/docs Documentation only labels Aug 11, 2026
@atkrad atkrad self-assigned this Aug 11, 2026
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/helm/helm.go 77.77% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@atkrad
atkrad merged commit 06ace4e into main Aug 11, 2026
17 checks passed
@atkrad
atkrad deleted the harden-helm-pending-and-crd-coverage branch August 11, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Commands, flags, UX copy area/deploy Deploy and plan session flow area/helm Chart render, release, post-render kind/bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant