add worker role and prometheus metrics - #75
Merged
Conversation
github-actions
Bot
added
kind/docs
- deploy role: worker as Deployment or StatefulSet without ClusterIP - emit ServiceMonitor or PodMonitor from profile metrics settings - bump manifest to v1-alpha.4 and platform to v1-alpha.3
atkrad
force-pushed
the
add-worker-role-and-metrics
branch
from
August 10, 2026 14:41
9a3d21f to
2caea4f
Compare
atkrad
added
kind/feature
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- cover metrics unmarshal, defaults, validation, and resolve errors - exercise monitor profile fields and RequiredAPIs in plan/deploy
- extract init apply helpers and non-interactive defaults - cover helm generate and RequiredAPIs edge cases - add health restartAfter and role-default tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship
role: workeras a long-running Deployment or StatefulSet. No ClusterIP or Ingress. Optionalhealth.alive.exec. ServiceMonitor for services, PodMonitor for workers. Platform profile ownsmetrics.monitorLabels.Bumped manifests to
v1-alpha.4(current isv1-alpha.5). Reject in-place role changes.Fixes #18. Finite work is
tasks:(#17), notrole: job.