feat(core): report why a resource is terminating#2597
Open
eofff wants to merge 8 commits into
Open
Conversation
ddc2b54 to
27b1c9d
Compare
added 8 commits
July 8, 2026 10:44
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
415707d to
b9d72ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
Deletingcondition toVirtualDisk,VirtualImage,ClusterVirtualImageandVirtualMachineBlockDeviceAttachmentexplaining why a resource is stuck inTerminating:DeletionBlockedByProtection— still attached to VirtualMachine(s) (listed in the message);CleanupPending— waiting for owned subresources (PVC, DataVolume, Pods, Service, Ingress, NetworkPolicy) to be removed.CleanUpnow returns a human-readable reason alongsiderequeue; shared condition/message/cleanup helpers live inserviceandcommon/vmto avoid duplication across the four controllers.Why do we need it, and what problem does it solve?
A resource stuck in
Terminatinggave no hint about what blocked deletion — the user had to inspect finalizers and subresources by hand. The cause is now visible directly instatus.conditions.What is the expected result?
While terminating, the
Deletingcondition names the blocker: an attached VM (protection) or the subresource being cleaned up (cleanup pending), then the object is removed once cleanup finishes.Checklist
Changelog entries