Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates agent-codemode to use a variant-neutral CodeSandboxClient API (instead of Sandbox/EvalSandbox) and aligns execution + tests with the new execute_code / execute_code_streaming methods.
Changes:
- Migrates executor/toolset/server integration to
CodeSandboxClientand renames sandbox plumbing (_sandbox→_sandbox_client,sandbox→sandbox_client). - Updates streaming execution tests to validate the streaming pathway and infrastructure-failure reporting.
- Refreshes examples/docs and normalizes dependency names/constraints in
pyproject.toml.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_skill_bindings.py | Updates test sandbox injection to use _sandbox_client and execute_code. |
| tests/test_executor_streaming.py | Renames sandbox mocks to client-style API and adds coverage for streaming infra failure behavior. |
| tests/test_executor_async.py | Updates async example/test script to CodeSandboxClient and execute_code. |
| pyproject.toml | Normalizes dependency names and updates version constraints (notably MCP and pydantic-ai optional deps). |
| examples/simple/agent_cli.py | Updates example wiring to create/pass a shared CodeSandboxClient. |
| docs/docs/skills/index.mdx | Updates documentation snippet to use CodeSandboxClient.create(variant="eval"). |
| agent_codemode/toolset.py | Renames toolset configuration field to sandbox_client and passes it into the executor. |
| agent_codemode/server.py | Uses executor.sandbox_client to inject context variables. |
| agent_codemode/composition/executor.py | Core migration to CodeSandboxClient, adds streaming collection logic, and updates sandbox lifecycle calls. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.