acc: run bundle/run/app-with-job locally#5820
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 438ee61
19 interesting tests: 15 SKIP, 4 RECOVERED
Top 5 slowest tests (at least 2 minutes):
|
Convert the app-with-job acceptance test to run against the local testserver in addition to cloud. The test drives the full app lifecycle (deploy, bundle run, apps stop, re-run), which the fake apps API did not model faithfully. Make the testserver app status mirror cloud: - AppsUpsert: a no_compute app (how bundle deploy always creates apps) now reports app_status UNAVAILABLE until started, instead of RUNNING. - AppsStart: starting the compute also brings the application up (RUNNING). - AppsStop: stopping the compute takes the application down (UNAVAILABLE) and returns the cloud "Start the app compute to deploy the app." message. Regenerate the goldens of sibling local apps tests, whose informational "App is in RUNNING state" bundle-run log line now correctly reads "App is in UNAVAILABLE state" for a not-yet-started no_compute app.
radakam
force-pushed
the
acc-local-app-with-job
branch
from
cca5ec6 to
07b0d29
Compare
janniklasrose
approved these changes
Jul 3, 2026
denik
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert
acceptance/bundle/run/app-with-jobto run against the local testserver in addition to cloud. The test drives the full app lifecycle (deploy →bundle run→apps stop→ re-run), which the fake Apps API did not model faithfully.Make the testserver app status mirror cloud:
AppsUpsert: ano_computeapp (howbundle deployalways creates apps) now reportsapp_statusUNAVAILABLEuntil started, instead ofRUNNING.AppsStart: starting the compute also brings the application up (RUNNING).AppsStop: stopping the compute takes the application down (UNAVAILABLE) and returns the cloud "Start the app compute to deploy the app." message.Regenerate the goldens of sibling local apps tests, whose informational
App is in RUNNING statebundle-run log now correctly readsApp is in UNAVAILABLE statefor a not-yet-startedno_computeapp.Why
This PR is part of the conversion to local tests.