AIR CLI: drop max_retries from the ai_runtime_task payload#5813
Open
riddhibhagwat-db wants to merge 1 commit into
Open
AIR CLI: drop max_retries from the ai_runtime_task payload#5813riddhibhagwat-db wants to merge 1 commit into
riddhibhagwat-db wants to merge 1 commit into
Conversation
On the ai_runtime_task path, retries are driven by the AI Runtime service, not the Jobs task max_retries field — setting it had no effect on execution retries (a run with max_retries=0 still retried). Stop sending max_retries / retry_on_timeout, matching the Python CLI's native path. The max_retries YAML field and its validation remain in the schema; it is simply not consumed on this submission path. Co-authored-by: Isaac
riddhibhagwat-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
riddhibhagwat-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Waiting for approvalCould not determine reviewers from git history. Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 3de55a3
23 interesting tests: 13 SKIP, 10 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request and its description were written by Isaac.
Changes
Stop sending
max_retries/retry_on_timeouton theai_runtime_tasksubmit payload. Both fields are removed from thesubmitTaskstruct and frombuildSubmitPayload. Themax_retriesYAML config field and its validation stay in the schema; it is simply no longer put on the wire for this submission path.Why
On the
ai_runtime_taskpath, execution retries are driven by the AI Runtime service (AICM), not by the Jobs taskmax_retriesfield — so setting it on the task had no effect on how many times a failing workload actually retried.Observed directly: a run submitted with
max_retries: 0still made 4 attempts (3 retries).air geton that run confirmed the field round-tripped correctly (Max Retries 0) while the workload retried anyway. The Python CLI's nativeai_runtime_taskbranch omitsmax_retriesfor the same reason; this matches that behavior.Leaving the field on the payload was misleading: a user setting
max_retries: 0to disable retries would still see retries.Tests
TestBuildSubmitPayloadasserts the marshaled task contains neithermax_retriesnorretry_on_timeout.TestBuildSubmitPayload_NoRetries(it asserted the now-removed field was sent).go test ./experimental/air/...and./task lint-qpass.