Add invariant test for deleting all resources#5810
Draft
denik wants to merge 2 commits into
Draft
Conversation
New delete invariant test deploys each config, replaces it with an empty bundle, then deploys again (with and without a saved plan) to delete all resources. Asserts the plan and summary are empty afterwards, then destroys. Co-authored-by: Isaac
Replace the inline head -n2 trick in the delete test with a committed empty.yml.tmpl config, and add it to the invariant matrix so no_drift, continue_293, and delete all exercise a resource-less bundle. Excluded from migrate, which has nothing to migrate without state. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 190d54f
23 interesting tests: 13 SKIP, 8 RECOVERED, 2 flaky
Top 5 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
deleteinvariant test that deploys each config, replaces it with an empty bundle, then deploys again (with and without a saved plan) to delete all resources. After deletion it asserts the plan and summary are empty, then destroys.The empty bundle is a new committed
configs/empty.yml.tmpl, added to the shared invariant matrix sono_drift,continue_293, anddeleteall exercise a resource-less bundle. It's excluded frommigrate, which has no state to migrate without resources.This pull request and its description were written by Isaac.