postgres: Support replace_existing on databases and roles#5803
Draft
pietern wants to merge 14 commits into
Draft
postgres: Support replace_existing on databases and roles#5803pietern wants to merge 14 commits into
pietern wants to merge 14 commits into
Conversation
Co-authored-by: Isaac
# Conflicts: # libs/structs/structwalk/walktype_test.go
Bump the pinned Databricks Terraform provider from v1.118.0 to v1.120.0, regenerate bundle/internal/tf/schema (and its ProviderVersion/checksums), and refresh the affected acceptance goldens. Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Extend the replace_existing pattern already used by postgres_branches and postgres_endpoints to databases and roles: a bundle can take over a database or role that already exists on a Lakebase branch instead of failing with ALREADY_EXISTS. The Terraform provider does not support replace_existing for databases/roles yet, so the new acceptance tests are locked to the direct engine for now. Co-authored-by: Isaac
The Terraform provider 1.120.0 bump adds replace_existing to the postgres_database and postgres_role schemas, so the new acceptance tests can run on terraform in addition to direct. The recorded request set diverges between engines (terraform omits the extra GET polls and includes parent in the body), so the deploy requests are split into per-engine out.requests.deploy.<engine>.json. Co-authored-by: Isaac
…ting-database-role # Conflicts: # NEXT_CHANGELOG.md # bundle/terraform_dabs_map/generated.go
Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 7d03762
227 interesting tests: 203 FAIL, 13 SKIP, 8 RECOVERED, 2 KNOWN, 1 flaky
Top 4 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the
replace_existingpattern already used bypostgres_branchesandpostgres_endpointstopostgres_databasesandpostgres_roles. Withreplace_existing: true, a bundle can take over a database or role that already exists on a Lakebase branch instead of failing withALREADY_EXISTS.This also merges the Terraform provider v1.120.0 bump, which adds
replace_existingto thepostgres_database/postgres_roleprovider schemas, so the new acceptance tests run on both the direct and terraform engines.This pull request and its description were written by Isaac.