Fail loudly when renew-certificate --restart cannot restart the control plane; include scheduler#1670
Open
Mukuwul wants to merge 2 commits into
Open
Fail loudly when renew-certificate --restart cannot restart the control plane; include scheduler#1670Mukuwul wants to merge 2 commits into
renew-certificate --restart cannot restart the control plane; include scheduler#1670Mukuwul wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes dapr mtls renew-certificate -k --restart so that control-plane restart failures are no longer silently ignored, and ensures the scheduler (introduced as a control-plane component in newer runtimes) is included in the restart when present.
Changes:
- Propagates and handles
restartControlPlaneService()errors, printing to stderr and exiting non-zero on failure. - Fails early if
GetDaprNamespace()cannot be determined (instead of continuing with an empty namespace). - Adds a conditional restart for
statefulsets/dapr-scheduler-serverby probing for its presence first.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if err != nil { | ||
| print.FailureStatusEvent(os.Stdout, err.Error()) | ||
| if err := restartControlPlaneService(); err != nil { | ||
| print.FailureStatusEvent(os.Stderr, err.Error()) |
Author
There was a problem hiding this comment.
Fixed in 339975f - switched to a constant format string. Side note: go vet on Go 1.26 flags ~50 pre-existing call sites across cmd/ with this same pattern, so a separate cleanup PR might be worth doing at some point.
Comment on lines
+183
to
187
| // The scheduler control plane service only exists for runtime 1.14 onwards, | ||
| // so restart it only when it is present in the cluster. | ||
| if _, err := utils.RunCmdAndWait("kubectl", "get", "statefulsets/dapr-scheduler-server", "-n", namespace); err == nil { | ||
| controlPlaneServices = append(controlPlaneServices, "statefulsets/dapr-scheduler-server") | ||
| } |
Author
There was a problem hiding this comment.
Done in 339975f - reworded both errors to be resource-agnostic since the list now includes statefulsets.
…ol plane dapr mtls renew-certificate --restart discarded the error returned by restartControlPlaneService and checked a stale err variable that is always nil at that point, so a failed control-plane restart still reported success with exit code 0. A namespace lookup failure was also ignored, producing 'kubectl rollout restart -n ""'. The restart list additionally omitted statefulsets/dapr-scheduler-server, which is part of the control plane since runtime 1.14 (reported in dapr#1574). The scheduler is restarted only when present so older clusters are unaffected. Fixes dapr#1669 Signed-off-by: Mukul <nmukul32@gmail.com>
…errors Signed-off-by: Mukul <nmukul32@gmail.com>
Mukuwul
force-pushed
the
fix/renew-cert-restart-errors
branch
from
July 18, 2026 21:33
bf7c9f8 to
339975f
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dapr mtls renew-certificate -k --restarthad three defects that combined to swallow every failure mode of the post-rotation control-plane restart:restartControlPlaneService()was discarded, and theif err != nilbeneath it tested a stale variable that is provably nil at that point (a non-nil value would already have exited vialogErrorAndExit). A failed restart still printed "Certificate rotation is successful!" and exited 0.statefulsets/dapr-scheduler-server, which is part of the control plane since runtime 1.14 — so the scheduler kept running with pre-rotation certificates (previously reported from the field in dapr mtls renew-certificate -k --valid-until <days> --restart did not restart statefulsets/dapr-scheduler-server #1574, closed stale).GetDaprNamespace()failure was printed and then ignored, producingkubectl rollout restart -n "".Changes:
restartControlPlaneService()error: print to stderr and exit 1.statefulsets/dapr-scheduler-serverto the restart list — probed withkubectl getfirst so clusters on runtime < 1.14 (no scheduler) are unaffected.Issue reference
Fixes #1669
Related: #1574 (field report of the missing scheduler restart, closed by the stale bot), #807 (mTLS rotation reliability epic)
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: