chore(auth): make Google One Tap the default, remove experiment flag#6326
Merged
capJavert merged 3 commits intoJul 15, 2026
Merged
Conversation
The auth_google_onetap experiment won, so drop the flag gate and let canUseOneTap alone drive One Tap. Removes featureAuthGoogleOneTap and the now-unused useConditionalFeature wiring in AuthOptionsInner. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
auth_google_onetapGrowthBook experiment won, so Google One Tap sign-in becomes the permanent baseline for all eligible users.featureAuthGoogleOneTapflag definition fromfeatureManagement.ts.useConditionalFeatureflag gate inAuthOptionsInner.tsx; One Tap is now driven solely by the existingcanUseOneTapeligibility guard (auth readiness, logged-out state, extension/iOS/Android-native exclusions).featureAuthGoogleOneTapanduseConditionalFeatureimports.Key decisions
useGoogleOneTap,betterAuthOneTapCallback, or the analytics events — those are the winning behavior and stay as-is.Testing
useGoogleOneTap.spec.ts(flag-agnostic,enabled-prop driven): 6/6 pass.Closes ENG-1868
Created by Huginn 🐦⬛
Preview domain
https://eng-1868-cleanup-google-one-tap.preview.app.daily.dev