Separate account preferences from shared agent configuration (DRU-504) - #494
Open
czpython wants to merge 4 commits into
Open
Separate account preferences from shared agent configuration (DRU-504)#494czpython wants to merge 4 commits into
czpython wants to merge 4 commits into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default execution appeared in both Agents and Preferences. A personal edit could also freeze an account's execution choices and prevent later shared changes from applying. Execution defaults now live only in Settings → Agents and apply to every account.
InstallationSettingsholds shared execution choices and the notification default for new accounts. Druks commits the singleton at startup before settings requests can run. Shared agent overrides and declared timeout priorities remain intact.Accountstores personal timezone and gate notification destination directly. New accounts copy the installation defaults once. Changing the notification default does not affect existing accounts; its API-only control is documented. Preferences works without execution catalogs.timezoneindruks.tomlcontrols schedules and operational day boundaries. Process and dotenvTIMEZONEvalues are ignored, including when TOML omits the key. Both setup and the development example include the timezone./settings/generalredirects to Preferences. Personal edits do not reschedule workflows. Setup and environment filtering share one set of top-level TOML keys.Agent.get_config()returns the temporaryAgentConfig. Platform callers, tests, and the author guide use the same name. It has no database table.Accounts retain their own subscriptions, MCP grants, and run attribution. Unattended runs use the default account.
Closes DRU-504.
Upgrade
Three forward-only migrations move existing preferences onto accounts, remove personal execution copies, and enforce one installation settings row. Existing personal values take priority; accounts without personal values receive the previous installation defaults.
Before upgrading a non-UTC installation, set
timezone = "Europe/Madrid"(or its current schedule timezone) at the top ofdruks.toml, before any table. The default is UTC. The database migration cannot update the deployment file.get_profile()is replaced byget_config()without an alias./api/settingsno longer accepts or returns timezone or account scope./api/settings/personalreturns only timezone and gate notification destination and rejects execution fields.The environment filter uses the
env_varsmapping from pydantic-settings for both process and dotenv sources. Regression tests cover this dependency. Nested JSON environment inputs keep their current behavior.Verification
No deployment. Live provider execution was not tested.