Bind the proxy to SECRETS_PROXY_BIND_HOST - #47
Merged
Merged
Conversation
The image's command fixed the listen host at 0.0.0.0, so a deployment on the host network restated the whole command to bind one interface. The bind host is now a variable with the same default. Verified with the built image: the variable binds 127.0.0.1:8880, its absence binds 0.0.0.0:8880. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
deploy/proxy/Dockerfilerunsmitmdumpthroughshand takes the listen host fromSECRETS_PROXY_BIND_HOST, default0.0.0.0. The port, the flow detail, and the addon stay in the command.docs/deploy.mdnames the variable besideSECRETS_EXCHANGE_URLand says when a deployment sets it: on the host network, to the one address its sandboxes dial, since an open listener on a public host is an open proxy.Where this differs from the ticket
mitmdumpcommand to change one flag, which the image was published to avoid.Names
SECRETS_PROXY_BIND_HOST, beside the exchange'sSECRETS_EXCHANGE_BIND_HOST.Gates
No Python changes. The built image was started twice: with the variable it listens at
127.0.0.1:8880, without it at0.0.0.0:8880, read from the container's socket table. CI builds the image.Review
Pending.
🤖 Generated with Claude Code