Accept plain HTTP issuer URLs - #43
Merged
Merged
Conversation
An issuer can run inside the same deployment as the exchange, where the exchange already answers the proxy over plain HTTP. Requiring HTTPS there forced a certificate and a trust store into every process that fetches, and protected nothing. The schema now accepts http and https. It still refuses credentials and fragments in the URL, since the URL is stored readable. The security and deploy docs say which scheme to use where. A header value is printable ASCII now, and a header that h11 refuses raises an IssuerError with no chain, so a value never reaches the log through the provisioning failure.
czpython
force-pushed
the
dru-469-http-issuer-urls
branch
from
September 7, 2026 10:47
5e20d22 to
b6e7fc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
SecretIssueracceptshttp://andhttps://issuer URLs. It still refuses user credentials and fragments in the URL, since the URL is stored readable and only the headers are encrypted.docs/security.mdanddocs/deploy.mdsay plain HTTP inside the deployment, HTTPS outside it.IssuerErrorwith no chain. A test proves the value stays out of the error.Where this differs from the ticket
docs/architecture.mdtoo. It states no scheme rule, so it does not change.Names
Renamed: the validator
require_secure_issuerisrefuse_secrets_in_url, which is what it checks now. New:refuse_control_characterson the headers.Gates
uv run ruff check,uv run ruff format --check,uv run pyright, anduv run pytestare green.Review
The adversarial review reported one finding, applied. The schema accepted a header value with a trailing newline. h11 refused it at request time with the whole value in its message,
Secret.fetchchained that message, and the provisioning failure log carried the chain. The defect predates this branch and reached the HTTP path too. Header values are printable ASCII now, and the h11 refusal raises a fixed message with no chain.