Conversation
Cyrix126
force-pushed
the
open_crypto_pay
branch
from
July 15, 2026 11:11
561bee5 to
9a00840
Compare
Cyrix126
marked this pull request as ready for review
July 18, 2026 11:03
Cyrix126
force-pushed
the
open_crypto_pay
branch
from
July 25, 2026 06:04
b788527 to
d5aa4e1
Compare
Collaborator
|
I merged this into https://github.com/cypherstack/stack_wallet/tree/julian/ocp since I believe at least one of the points Reuben posted is addressed by changes I made in another branch that forms the base of the julian/ocp branch. I will leave this PR open for now |
Contributor
Author
Indeed the ocp branch has reworked min fees so it's better to work from it. I'm merging ocp into this branch and fixing the rest that is relevant from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some notes:
feat: refactor some part of lib/pages/send_view/confirm_transaction_view.dart to avoid dupplicating code
feat: add an http client class that can be used for library needing a Client from the http package as parameter
fix: Add missing qr scan button on the token view for desktop