Export a public reconnect/retry signal for TypeScript SDK embedders - #58
Open
rajarshidattapy wants to merge 3 commits into
Open
rajarshidattapy wants to merge 3 commits into
rajarshidattapy wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
… SDK stream open. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit 73faa6b. Configure here.
…ging Enhance the watchStream functionality by ensuring that cleanup does not hang if the consumer stops while in the RETRYING state. This change includes a new test case to validate the behavior, ensuring that the iterator closes properly without causing delays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@cursor/sdkembedders keeplocal.enableAgentRetries: trueso stalled transport can recover, but the SDK does not export reconnect or retry state.onConnectionStateChangehub (reconnecting/connected) and aRETRYINGstream status so an idle timeout can pause during an in-progress SDK reconnect instead of looking like a dead model.Test plan
cd sdk/reconnect-signal && pnpm install && pnpm testpnpm typecheckpnpm devprintsRUNNING→ reconnecting →RETRYING→ connected →FINISHEDCURSOR_API_KEY=... pnpm dev -- --live