fix: branch resolution#25
Conversation
|
Hey SP, thanks for the note. It's been a while since I touched this repo, but I recall I didn't get as far as the delegation paths, so this might be totally unimplemented from what I recall. |
|
|
||
| let mut unlocked = match Comrade::new(&kvp_lock, &entry).try_unlock(unlock) { | ||
| let mut unlocked = match Comrade::new(&kvp_lock, &entry) | ||
| .with_domain(&domain) |
There was a problem hiding this comment.
From what I recall, this looks about right. I am surprised I missed this, this line was the whole point of with_domain()
Thanks for the review! I also plan to update the dependencies in the future but I have to switch back to my previous project for now. Hopefully this can be merged soon. 🙏 If everything goes according to plan this will be used as the foundational tech for the Logos Identity stack. :O I'm pretty excited. |
My AI found this. Let me know what ya think.