ci: run the publish job on Node 24 - #8
Merged
Merged
Conversation
The publish job pinned Node 20 and then ran `npm install -g npm@latest` to get a version new enough for trusted publishing. npm 12 requires Node ^22.22.2 || ^24.15.0 || >=26.0.0, so that step now fails with EBADENGINE and no publish can complete — including the prerelease chained off a green CI run on main. Move the pin to Node 24, which npm@latest supports. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
publishjob has been failing for every commit since npm 12 shipped, so no release — stable or prerelease — can go out. It first surfaced on the run chained off #7's merge (run 32138453942):actions/setup-nodepinsnode-version: '20', then the next step runsnpm install -g npm@latestto reach the npm ≥ 11.5.1 that OIDC trusted publishing needs. npm 12 dropped Node 20, so the two steps now contradict each other. Nothing about the repo changed — the last successful publish was 0.4.5 in June, before npm 12.Change
Move the pin to Node 24, which
npm@latestsupports, and note the constraint next to it so the next drift is easier to spot.ciis unaffected (it uses Bun, not this Node setup).Verification
Cannot be verified before merge:
publishonly triggers on a tag push or on a completedcirun onmain, so it will not run from a PR branch. The failure mode is a hard engine check with an explicit supported range, and Node 24 sits inside it.After merge, the CI run on
mainshould chain into a successful publish of a0.4.5-next.<N>.g<sha>prerelease under thenextdist-tag.🤖 Generated with Claude Code