Fix invalid cast for x-ms-paths required arrays - #103
Open
Jerry-Johnson-3 wants to merge 1 commit into
Open
Jerry-Johnson-3 wants to merge 1 commit into
Jerry-Johnson-3 wants to merge 1 commit into
Conversation
Build a HashSet from required property names instead of casting a LINQ projection to ISet<string>. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selectprojection toISet<string>when convertingrequiredarrays onx-ms-pathsschemas.required: [name].That cast throws
InvalidCastExceptionwhenever a custom path schema includesrequired.Spec
requiredis a JSON Schema array of unique strings (OAS Schema Object takes this keyword unchanged). The crash is a C# invalid cast:Enumerable.SelectreturnsIEnumerable<string>, notISet<string>.requiredtaken from JSON Schema)requiredMUST be an array of unique strings)x-ms-pathsitself is an AutoRest specification extension, not an OAS keyword; therequiredarray on schemas inside it is still JSON Schemarequired.Testing
ToOpenApiPaths_ConvertsSchemaRequiredArraythrewInvalidCastException.HashSet<string>.