Fix OpenApiFloat comparison threshold - #102
Open
Jerry-Johnson-3 wants to merge 1 commit into
Open
Jerry-Johnson-3 wants to merge 1 commit into
Jerry-Johnson-3 wants to merge 1 commit into
Conversation
Use float.Epsilon instead of float.MinValue so equal float defaults are not reported as different. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
float.Epsiloninstead offloat.MinValueinDifferFromso equal float defaults are not reported as different.OpenApiFloatvalues.float.MinValueis a large negative number, soMath.Abs(a - b) > float.MinValueis true for every pair of floats, including identical ones.Spec
OpenAPI
number/floatis IEEE 754 binary32. Equal defaults must compare equal.Single.MinValueis the most negative finite value (~-3.4e38), not a comparison epsilon.number/float)Testing
DifferFrom_ShouldReturn_false_When_SameOpenApiFloatfailed (Expected: False, But was: True).