Fix backwards date comparison - #101
Open
Jerry-Johnson-3 wants to merge 1 commit into
Open
Jerry-Johnson-3 wants to merge 1 commit into
Jerry-Johnson-3 wants to merge 1 commit into
Conversation
Date defaults were reported as changed when equal and ignored when different because the DateTime difference predicate returned equality directly. Add regression tests for both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateTimecomparison.Spec
OpenAPI 3.0
datevalues are RFC 3339full-dates, and Schemadefaultis a value of that type. Two equal dates are the same default;DifferFrommust return false for them, matching the other primitive overloads.string/date→ RFC 3339full-date)full-date)defaultTesting
dotnet test— 98 passed on .NET 6 and .NET 8.