Conversation
fix and tests fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like gcc17 will add __builtin_bitreverse when it releases. This implementation mirrors the bswap implementation.
https://gcc.gnu.org/onlinedocs/gcc/Byte-Swapping-Builtins.html
Unfortunately, both __builtin_bitreverse64 and __builtin_bswap64 both don't work quite right because of #14154. ALso, bswap uses the "ul*" suffixes for its hex literals but I think those have no impact and the values are always stored as "bigint" (long long, unless we are able to use a 128 bit integer).