Skip to content

test(embed): make the session-canonicalize IT actually exercise the beforeLoad guard #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omridevk merged 1 commit into from
Aug 16, 2026
Merged

test(embed): make the session-canonicalize IT actually exercise the beforeLoad guard #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 36 additions & 8 deletions packages/embed/tests/e2e/session-canonicalize.it.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,56 @@ import {openPanel} from './helpers/panel.js'

const RAW_HARNESS_ID = '43548fd1-0000-4220-acf0-014b10b5815f'
const EXTERNAL_TITLE = 'a session started outside conciv'
const NEWER_HARNESS_ID = '9f2c77aa-1111-4a10-b3d1-77c0a2e9b004'
const NEWER_TITLE = 'the newest session outside conciv'

const suite = setupWidgetSuite({
history: [{id: RAW_HARNESS_ID, derivedTitle: EXTERNAL_TITLE, updatedAt: Date.now(), messageCount: 3}],
history: [
{id: NEWER_HARNESS_ID, derivedTitle: NEWER_TITLE, updatedAt: Date.now(), messageCount: 1},
{id: RAW_HARNESS_ID, derivedTitle: EXTERNAL_TITLE, updatedAt: Date.now() - 60_000, messageCount: 3},
],
})

test.describe('switching to a harness session conciv has never adopted', () => {
test('lands the panel on the canonical conciv session route, not the raw harness id', async ({page}) => {
test.setTimeout(180_000)
const listed = await suite.kit().rpc.sessions.list()
expect(listed.map((meta) => meta.id)).toContain(RAW_HARNESS_ID)
const adoptedExternalId = async (): Promise<string | undefined> => {
const metas = await suite.kit().rpc.sessions.list()
return metas.find((meta) => meta.title === EXTERNAL_TITLE && meta.id.startsWith('conciv_'))?.id
}

const listed = (await suite.kit().rpc.sessions.list()).map((meta) => meta.id)
expect(listed).toContain(NEWER_HARNESS_ID)
expect(listed).toContain(RAW_HARNESS_ID)

await page.goto(suite.host().base, {waitUntil: 'domcontentloaded'})
await openPanel(page)

await until(
async () => {
const ids = (await suite.kit().rpc.sessions.list()).map((meta) => meta.id)
return !ids.includes(NEWER_HARNESS_ID) && ids.includes(RAW_HARNESS_ID)
},
{hangGuardMs: 30_000, intervalMs: 100},
)
const afterWarmResolve = (await suite.kit().rpc.sessions.list()).map((meta) => meta.id)
expect(afterWarmResolve).not.toContain(NEWER_HARNESS_ID)
expect(afterWarmResolve).toContain(RAW_HARNESS_ID)

await page.getByRole('button', {name: /^Session: /}).click()
await page.getByRole('option', {name: new RegExp(EXTERNAL_TITLE)}).click()
const option = page.getByRole('option', {name: new RegExp(EXTERNAL_TITLE)})
await expect(option).toBeVisible({timeout: 30_000})
await option.click()

await expect(page.getByRole('button', {name: `Session: ${EXTERNAL_TITLE}`})).toBeVisible({timeout: 30_000})
await until(async () => (await currentHref(suite.kit())).startsWith('/panel/conciv_'), {
hangGuardMs: 30_000,
intervalMs: 100,
})
await until(
async () => {
const canonicalId = await adoptedExternalId()
if (!canonicalId) return false
return (await currentHref(suite.kit())).includes(canonicalId)
},
{hangGuardMs: 30_000, intervalMs: 100},
)

const adopted = await suite.kit().rpc.sessions.resolve({id: RAW_HARNESS_ID})
const href = await currentHref(suite.kit())
Expand Down
Loading