chore: add stricter review rules for complytime repo - #213
Merged
marcusburghardt merged 1 commit intoSep 4, 2026
Merged
Conversation
marcusburghardt
requested review from
gxmiranda,
jflowers and
jpower432
as code owners
September 3, 2026 15:07
Add repo-level safe-settings override for complytime requiring 2 approvers and stale review dismissal, matching the existing manual "main" ruleset (id=17986337). Differences from the non-code-repos baseline: - required_approving_review_count: 1 -> 2 - dismiss_stale_reviews_on_push: false -> true Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt
force-pushed
the
chore/complytime-stricter-review
branch
from
September 4, 2026 09:21
e4f1a0c to
652721b
Compare
marcusburghardt
enabled auto-merge (rebase)
September 4, 2026 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a repo-level safe-settings override for
complytimerequiring stricterreview rules than the non-code-repos baseline, matching the existing manual
"main" ruleset (id=17986337).
Differences from non-code-repos baseline
required_approving_review_countdismiss_stale_reviews_on_pushrequire_code_owner_reviewrequire_last_push_approvalrequired_review_thread_resolutionNotes
The file was initially copied from
repos/complyctl.ymlbut had twoissues that are fixed in this PR:
require_last_push_approvalwas set totrue(from complyctl),but complytime's manual ruleset has
false.Updated to reflect that complytime is in the non-code-repos suborg.
After merging, run the safe-settings sync for complytime to create the
repo-level ruleset, then the manual "main" ruleset (id=17986337) can be
removed.