Fix polyhedron vertices - points - #1527
Open
ericgozzi wants to merge 2 commits into
Open
Conversation
points to list[x, y, z], when initiated as vertices: list[Point].
gonzalocasas
requested changes
Aug 10, 2026
gonzalocasas
left a comment
Member
There was a problem hiding this comment.
mmm... this has two problems:
- performance is not the best, because it iterates twice over all vertices (first to check
all()and then to convert to lists), and - [this is a bit more problematic] vertices are not always going to be instances of
Point, compas accepts lists/tuples/etc that can be iterated as valid points, so, this code would break that assumption
may I ask what's the trigger for changing this? Have you observed a bug in other code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the vertices setter to convert list[Point] into a list of coordinates list[list[int]]. The Polyhedron.vertices attribute now always returns a list of vertices (list[list[int]]).
The behavior now matches the docstring.
test_polyhedron_verticesintest_polyhedron.pyto verify that thePolyhedronclass correctly handles both lists of coordinates and lists ofPointobjects as vertices.Pointin the test file to support the new test case.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.