Added docs in OKF format#79
Merged
Merged
Conversation
Coverage Report for CI Build 28056019167Coverage remained the same at 98.476%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
nedbat
reviewed
Jun 23, 2026
|
|
||
| # Citations | ||
|
|
||
| [1] [src/portable_python/__init__.py — BuildSetup](https://github.com/codrsquad/portable-python/blob/main/src/portable_python/__init__.py) |
There was a problem hiding this comment.
Is this meant to be referred to from somewhere?
Contributor
Author
There was a problem hiding this comment.
Removed all citations now 👍 they were indeed all superfluous
nedbat
reviewed
Jun 23, 2026
| @@ -0,0 +1,51 @@ | |||
| --- | |||
| type: Class | |||
There was a problem hiding this comment.
Why is a page about a class better than a docstring in the code? How do we decide what to put where?
Contributor
Author
There was a problem hiding this comment.
Good point! Rephrased everything to avoid repeating anything from code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added docs in OKF format https://github.com/GoogleCloudPlatform/knowledge-catalog/blob/main/okf/SPEC.md