Skip to content

Surface subscription validation errors instead of a generic message - #1919

Draft
schneems wants to merge 15 commits into
mainfrom
schneems/doc-generation-trust-gating
Draft

schneems wants to merge 15 commits into
mainfrom
schneems/doc-generation-trust-gating

Conversation

@schneems

Copy link
Copy Markdown
Member

On a failed create/update, show the actual validation messages (e.g. the doc trust-gate reason, or an invalid email-limit) via errors.full_messages, falling back to "Something went wrong" only when no message is present. Previously a user blocked by the <7-day doc gate through the controller saw a generic error and never the carefully-worded reason.

Anti-abuse trust-gating for the YARD doc-generation pipeline: a hard 7-day / active-others gate on enabling docs at subscribe time, per-subscription inactivity tracking (repo_subscriptions.docs_last_click_at) with a one-click signed-link re-opt-in email, and a global ENV kill switch. docs_subscriber_count is redefined to count only active doc subscriptions. Scope is trust-gating only; execution hardening is tracked separately.

Pending review before the implementation plan is written.
On a failed create/update, show the actual validation messages (e.g. the doc trust-gate reason, or an invalid email-limit) via errors.full_messages, falling back to "Something went wrong" only when no message is present. Previously a user blocked by the <7-day doc gate through the controller saw a generic error and never the carefully-worded reason.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant