[codex] Add GitHub Actions CI#142
Merged
Merged
Conversation
Add CI jobs for server lint/unit tests, client lint/unit tests, and Cypress. Scaffold a root Cypress setup with a smoke spec so future browser tests can be added incrementally.
Format the existing events list so the new client lint CI job can pass without weakening the lint check.
Pin the client/Netlify build to Node 14.21.3, matching the CI client job and the node-sass 4 toolchain.
Mirror the existing Netlify client build settings in repo config and pin Node 14.21.3 for the old node-sass based client build.
Run the Netlify build from the repository root while entering client explicitly, and publish client/build. Keep Node 14 pinned for the old client toolchain.
Add a root .nvmrc so Netlify and other repo-root tooling pick up Node 14.21.3 for the current client toolchain.
Skip client install scripts on Netlify to avoid native node-sass rebuilds and apply the Webpack 4 OpenSSL legacy provider only on modern Node.
Allow the deploy-preview build command to run from either the repository root or the existing client base directory.
Set the Netlify base directory and publish path explicitly so deploy previews run the legacy client build from client/.
Mirror the deploy-preview build settings under client/ so Netlify can resolve them when the site base directory is client.
Re-run Netlify after aligning project build settings with the repo config.
Install the client from the lockfile on deploy previews so Netlify does not reuse stale cached node_modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master.node-sass@4toolchain better than modern Node.server/middlewares/auth.jsso the new server lint job starts green.Validation
Local checks run:
cd server && npm run lintcd server && npm testnpm run cypress:runNot run locally:
node-sass@4, so the workflow runs the client job on Node 14.21.3 instead.Notes
The Cypress spec is intentionally a minimal smoke test for CI wiring. It gives us the framework and a passing baseline; app-level Cypress tests can be added after this lands.