Skip to content

feat: share new chats with the organization, groups, or users - #42

Merged
bpmct merged 4 commits into
mainfrom
feat/share-with-organization
Sep 14, 2026
Merged

feat: share new chats with the organization, groups, or users#42
bpmct merged 4 commits into
mainfrom
feat/share-with-organization

Conversation

@bpmct

@bpmct bpmct commented Sep 11, 2026

Copy link
Copy Markdown
Member

Chats created by background workflows are owned by the bot token, so the link they post answers "Chat not found" for everyone else. New share-with-organization, share-with-groups, and share-with-users inputs (all off by default) grant read access on a newly created chat, so people can follow the agent's reasoning, not just its verdict. First use is doc-check, where the docs team wants to open a review and see how it got there.

Generated by Coder Agents on behalf of @bpmct.

Chats are owned by the coder-token holder, so the chat-url the action
posts answers "Chat not found" for everyone else. share-with-organization
grants the chat's organization read access on creation, off by default.
One sharing module resolves the share-with-* inputs to the UUIDs the ACL
API requires and sends a single PATCH. Names resolve through the users
and groups endpoints, UUIDs pass through, and the token owner is dropped
because the API rejects a self-share.
@bpmct bpmct changed the title feat: share a new chat with its organization on request feat: share new chats with the organization, groups, or users Sep 11, 2026
@bpmct
bpmct requested a review from mafredri September 11, 2026 17:13

@coder-agents-review coder-agents-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing review: the README incorrectly excludes subagent chats from root sharing. Other comments address access/interface descriptions, recovery advice, and optional wording improvements.

Apply the warning-text suggestion and its matching test assertion together, then rebuild the action bundle. Scope: documentation, comments, messages, and test names.

🤖 This review was automatically generated with Coder Agents.

EDIT: This was not supposed to go through coder-agents-review bot app, but my account (sorry about that 😅). // @mafredri

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread README.md Outdated
Comment thread src/sharing.ts Outdated
Comment thread src/sharing.ts Outdated
Comment thread src/sharing.test.ts Outdated
Comment thread src/coder-client.test.ts Outdated
Comment thread src/sharing.test.ts Outdated

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems like a useful addition! Had my agent add some suggestions and fix a few correctness claims.

Address review suggestions for sharing scope, input descriptions, and UUID lookup guidance. Update the matching tests and rebuild the action bundle.

Generated by Coder Agents on behalf of @bpmct.
@bpmct

bpmct commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Thanks!!

@bpmct
bpmct merged commit 3e20636 into main Sep 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants