feat: share new chats with the organization, groups, or users - #42
Merged
Conversation
Chats are owned by the coder-token holder, so the chat-url the action posts answers "Chat not found" for everyone else. share-with-organization grants the chat's organization read access on creation, off by default.
One sharing module resolves the share-with-* inputs to the UUIDs the ACL API requires and sends a single PATCH. Names resolve through the users and groups endpoints, UUIDs pass through, and the token owner is dropped because the API rejects a self-share.
There was a problem hiding this comment.
Writing review: the README incorrectly excludes subagent chats from root sharing. Other comments address access/interface descriptions, recovery advice, and optional wording improvements.
Apply the warning-text suggestion and its matching test assertion together, then rebuild the action bundle. Scope: documentation, comments, messages, and test names.
🤖 This review was automatically generated with Coder Agents.
EDIT: This was not supposed to go through coder-agents-review bot app, but my account (sorry about that 😅). // @mafredri
mafredri
approved these changes
Sep 14, 2026
mafredri
left a comment
Member
There was a problem hiding this comment.
Thanks, this seems like a useful addition! Had my agent add some suggestions and fix a few correctness claims.
Address review suggestions for sharing scope, input descriptions, and UUID lookup guidance. Update the matching tests and rebuild the action bundle. Generated by Coder Agents on behalf of @bpmct.
Member
Author
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chats created by background workflows are owned by the bot token, so the link they post answers "Chat not found" for everyone else. New
share-with-organization,share-with-groups, andshare-with-usersinputs (all off by default) grant read access on a newly created chat, so people can follow the agent's reasoning, not just its verdict. First use isdoc-check, where the docs team wants to open a review and see how it got there.