Fix/5662 default content type sba settings - #5670
Open
ulischulte wants to merge 4 commits into
Open
ulischulte wants to merge 4 commits into
ulischulte wants to merge 4 commits into
Conversation
…auto-config contexts
ulischulte
marked this pull request as draft
September 18, 2026 21:27
- Reverted UiController.sbaSettings() to normal Thymeleaf view rendering. - Preserves Spring/Thymeleaf web context. - Avoids _csrf regression. - Removed misleading JSON produces. - /sba-settings.js again truthfully produces only application/javascript. - Explicit Accept: application/json now returns 406. - Added servlet-only filter for /sba-settings.js. - Rewrites missing/blank/wildcard Accept to application/javascript. - Fixes #5662 without changing WebFlux behavior. - Added regression test for explicit JSON accept.
ulischulte
marked this pull request as ready for review
September 18, 2026 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5662
Issue #5662 happens when an app sets Spring MVC’s default content type to JSON. Then /sba-settings.js requests with no specific Accept header get treated as JSON requests, but SBA only serves that endpoint as JavaScript, causing 406 Not Acceptable.
This branch fixes it by adding a servlet-only filter for /sba-settings.js that changes missing or wildcard Accept headers to application/javascript. Explicit wrong headers, like Accept: application/json, still return 406. Tests reproduce the JSON default-content-type setup and verify both success and rejection cases.
Validated against demo in issue (spring-boot-admin-demo.zip)