V10.7.1/service update - #170
Open
gimlichael wants to merge 8 commits into
Open
Conversation
The IDE0036 rule section was duplicated. Removed the redundant entry to keep the configuration file clean and consistent.
Reorganized the contributing guide to align with Codebelt shared conventions, clarify repository shape, provide detailed build/test/package instructions, and establish clear CI contract. Documentation now focuses on actionable developer workflows with explicit test matrix and integration test requirements.
Updated central package versions to latest releases: Codebelt.Extensions.Xunit and related packages to v12.0.0, xunit.v3 and runner to v4.0.0, MinVer to v8.0.0, and Microsoft.NET.Test.SDK to v18.9.0. These updates bring the latest testing framework and tooling improvements.
Consolidated multiple Docker test environment variants into a single multi-version image configuration. Changed from separate Docker-Ubuntu (net9) and Docker-Ubuntu (net10) entries to a single Docker-Ubuntu entry using the codebeltnet/ubuntu-testrunner:8-9-10-11 image that supports all required .NET versions in one container.
|
|
||
| ## Test | ||
|
|
||
| Run tests one project at a time so a failing or hanging project is attributable. This mirrors the CI matrix; it does not silently turn skipped integration tests into passing tests. |
There was a problem hiding this comment.
The shown loop runs only with --configuration Release, but the text says it matches the automated checks, which also run Debug. Contributors can follow this guidance and miss a Debug-specific regression until it is caught remotely. This is a non-blocking documentation concern; either run both configurations locally or describe this as a Release-only validation pass.
Suggested change
| Run tests one project at a time so a failing or hanging project is attributable. This mirrors the CI matrix; it does not silently turn skipped integration tests into passing tests. | |
| Run tests one project at a time so a failing or hanging project is attributable. This provides a Release-only validation pass; it does not silently turn skipped integration tests into passing tests. |
Artifacts
- Authored Bash script that extracts and compares the documented test configuration with the current workflow test matrices, ending with the configuration-parity result.
- Captured output from executing the comparison script in `/home/user/repo`; it shows Release in the documentation and Debug,Release in CI, confirming the mismatch.
Ran code and verified through T-Rex
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/CONTRIBUTING.md
Line: 33
Comment:
**Release loop misses Debug**
The shown loop runs only with `--configuration Release`, but the text says it matches the automated checks, which also run Debug. Contributors can follow this guidance and miss a Debug-specific regression until it is caught remotely. This is a non-blocking documentation concern; either run both configurations locally or describe this as a Release-only validation pass.
```suggestion
Run tests one project at a time so a failing or hanging project is attributable. This provides a Release-only validation pass; it does not silently turn skipped integration tests into passing tests.
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Switch code coverage tool from coverlet to Microsoft.Testing.Extensions.CodeCoverage and configure the Microsoft.Testing.Platform via global.json for improved test infrastructure alignment.
Remove DisableAppDomain argument from CI test runner configuration as it is no longer needed with Microsoft.Testing.Platform.
Update the test execution examples in CONTRIBUTING.md to use the modern --project flag syntax instead of positional arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates repository documentation, test infrastructure, and dependency versions to improve clarity, maintainability, and consistency. The most significant changes include a complete rewrite of the contributing guide, consolidation of test environments, and upgrades to several package dependencies.
Documentation and contribution process:
.github/CONTRIBUTING.mdfile has been completely rewritten for clarity and detail. It now provides explicit instructions for building, testing, and contributing, explains the repository structure, CI contract, and coding guidelines, and clarifies the process for issues and pull requests.Test infrastructure and environment:
testenvironments.jsonfile now consolidates Docker test environments into a single entry using the unifiedcodebeltnet/ubuntu-testrunner:8-9-10-11image, simplifying cross-version testing.Dependency and package management:
Directory.Packages.propshave been upgraded, includingCodebelt.Extensions.Xunit(to 12.0.0),xunit.v3(to 4.0.0),Microsoft.NET.Test.Sdk(to 18.9.0), and variousMicrosoft.*packages, ensuring compatibility and access to new features. [1] [2]Editor configuration cleanup:
IDE0036analyzer has been removed from.editorconfigto avoid inconsistencies.