Skip to content

V10.7.1/service update - #170

Open
gimlichael wants to merge 8 commits into
mainfrom
v10.7.1/service-update
Open

V10.7.1/service update#170
gimlichael wants to merge 8 commits into
mainfrom
v10.7.1/service-update

Conversation

@gimlichael

Copy link
Copy Markdown
Member

This pull request updates repository documentation, test infrastructure, and dependency versions to improve clarity, maintainability, and consistency. The most significant changes include a complete rewrite of the contributing guide, consolidation of test environments, and upgrades to several package dependencies.

Documentation and contribution process:

  • The .github/CONTRIBUTING.md file has been completely rewritten for clarity and detail. It now provides explicit instructions for building, testing, and contributing, explains the repository structure, CI contract, and coding guidelines, and clarifies the process for issues and pull requests.

Test infrastructure and environment:

  • The testenvironments.json file now consolidates Docker test environments into a single entry using the unified codebeltnet/ubuntu-testrunner:8-9-10-11 image, simplifying cross-version testing.

Dependency and package management:

  • Several dependencies in Directory.Packages.props have been upgraded, including Codebelt.Extensions.Xunit (to 12.0.0), xunit.v3 (to 4.0.0), Microsoft.NET.Test.Sdk (to 18.9.0), and various Microsoft.* packages, ensuring compatibility and access to new features. [1] [2]

Editor configuration cleanup:

  • Duplicate and unnecessary configuration for the IDE0036 analyzer has been removed from .editorconfig to avoid inconsistencies.

The IDE0036 rule section was duplicated. Removed the redundant entry to keep the configuration file clean and consistent.
Reorganized the contributing guide to align with Codebelt shared conventions, clarify repository shape, provide detailed build/test/package instructions, and establish clear CI contract. Documentation now focuses on actionable developer workflows with explicit test matrix and integration test requirements.
Updated central package versions to latest releases: Codebelt.Extensions.Xunit and related packages to v12.0.0, xunit.v3 and runner to v4.0.0, MinVer to v8.0.0, and Microsoft.NET.Test.SDK to v18.9.0. These updates bring the latest testing framework and tooling improvements.
Consolidated multiple Docker test environment variants into a single multi-version image configuration. Changed from separate Docker-Ubuntu (net9) and Docker-Ubuntu (net10) entries to a single Docker-Ubuntu entry using the codebeltnet/ubuntu-testrunner:8-9-10-11 image that supports all required .NET versions in one container.
@gimlichael gimlichael self-assigned this Sep 8, 2026
@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

Safe to merge with respect to blocking issues; the remaining documentation concern is non-blocking.

Summary

  • This change modernizes the test infrastructure and contributor documentation for the Microsoft Testing Platform and current xUnit setup. The existing contributor-guide documentation concern remains open: its Release-only test loop is described as mirroring CI even though CI also runs Debug.

Comment thread .github/CONTRIBUTING.md

## Test

Run tests one project at a time so a failing or hanging project is attributable. This mirrors the CI matrix; it does not silently turn skipped integration tests into passing tests.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Release loop misses Debug

The shown loop runs only with --configuration Release, but the text says it matches the automated checks, which also run Debug. Contributors can follow this guidance and miss a Debug-specific regression until it is caught remotely. This is a non-blocking documentation concern; either run both configurations locally or describe this as a Release-only validation pass.

Suggested change
Run tests one project at a time so a failing or hanging project is attributable. This mirrors the CI matrix; it does not silently turn skipped integration tests into passing tests.
Run tests one project at a time so a failing or hanging project is attributable. This provides a Release-only validation pass; it does not silently turn skipped integration tests into passing tests.
Artifacts

Evidence from the check

  • Authored Bash script that extracts and compares the documented test configuration with the current workflow test matrices, ending with the configuration-parity result.

Command output from the check

  • Captured output from executing the comparison script in `/home/user/repo`; it shows Release in the documentation and Debug,Release in CI, confirming the mismatch.

View artifacts

T-Rex Ran code and verified through T-Rex

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/CONTRIBUTING.md
Line: 33

Comment:
**Release loop misses Debug**

The shown loop runs only with `--configuration Release`, but the text says it matches the automated checks, which also run Debug. Contributors can follow this guidance and miss a Debug-specific regression until it is caught remotely. This is a non-blocking documentation concern; either run both configurations locally or describe this as a Release-only validation pass.

```suggestion
Run tests one project at a time so a failing or hanging project is attributable. This provides a Release-only validation pass; it does not silently turn skipped integration tests into passing tests.
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Codex

gimlichael and others added 4 commits September 9, 2026 02:03
Switch code coverage tool from coverlet to Microsoft.Testing.Extensions.CodeCoverage and configure the Microsoft.Testing.Platform via global.json for improved test infrastructure alignment.
Remove DisableAppDomain argument from CI test runner configuration as it is no longer needed with Microsoft.Testing.Platform.
Update the test execution examples in CONTRIBUTING.md to use the modern --project flag syntax instead of positional arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants