feat(blocklist): launch blocking, drop blocklist beta flag - #1189
Merged
Conversation
Removes the blocklist_enabled beta flag and makes blocking always-on, following the same launch pattern used for tipping. - Delete the FeatureFlag.Blocklist definition (title/message arms); KSP drops it from FeatureFlagEntries and the Labs UI. - MyAccount 'Blocked' menu item no longer flag-gated. - ChatViewModel: remove the flag observe, blocklistEnabled state, BlocklistEnabledChanged event/reducer, and the now-unused FeatureFlagController injection. canViewProfile keys solely off TIP_DM. - Refresh comments in messenger UI that referenced the flag. - Drop blocklist_enabled from the MainActivity test launch-arg example and the Maestro blocking flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launches blocking to all users by removing the
blocklist_enabledbeta flag and making the feature always-on. Follows the same two-step launch pattern used for Tipping (#1182).Changes
FeatureFlag.kt— deleted theBlocklistflag definition and itstitle/messagearms. KSP regeneratesFeatureFlagEntries, so it also drops out of the Labs settings UI.MyAccountMenuItems.kt— the "Blocked" menu item is no longer flag-gated; it shows for everyone.ChatViewModel.kt— removed the flag observe, theblocklistEnabledstate field, theBlocklistEnabledChangedevent + reducer arm, and the now-unusedFeatureFlagControllerinjection/imports.canViewProfilenow keys solely offchatType == TIP_DM.MessengerScreen.kt/ChatTopBar.kt/MessageList.kt— refreshed comments that referenced the beta flag (gating logic unchanged; it already keyed offcanViewProfile).MainActivity.kt/maestro/blocking.yaml— retiredblocklist_enabledfrom the UI-test launch-arg example and the Maestro blocking flow (now logs in with empty beta flags, matching the tip flows).The actual blocklist feature (
AppRoute.Menu.Blocklistscreen, block/unblock flows) is untouched — only the gating is removed.Testing
:featureflags,:myaccount,:messenger, and:appcompile (compileDebugKotlin).:myaccountunit tests pass.