review: whole-repo round — net rollback, stray-helper reap, NBD busy check, VNC password rules; pin cocoon - #39
Merged
Merged
Conversation
…check, VNC password rules; pin cocoon 51ff88b provisionNet rolls its netns back through a shared toggleNet; createVM reaps stray qemu/qemu-nbd helpers by cmdline before relaunch; the NBD busy check reads /proc cmdlines through a testable seam; VNC passwords reject whitespace; clone inherits the source's network mode unless --net is set; OpenStore takes the caller's context. cocoon is pinned to its merged head (ReflinkCopy takes a context, Network.Delete takes one id, the image JSON namespace comes from core.ImageJSONNamespace).
… resolve the proxy name once A VM dir needle without its separator also matched foo-clone's processes; vmDirPrefix carries the slash for every cmdline scan. A bridge-mode clone inherited the mode but not the bridge, so applyNet refused it. The VNC proxy name is resolved once per process, the clone inheritance is documented, and the last test narration is gone.
…last test comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whole-repo quality round for cocoon-macos, plus the cocoon dependency pinned to its merged head.
Correctness:
Dependency: cocoon v0.6.2-0.20260902190340-51ff88bcf8f1 (merged head of #208) — ReflinkCopy takes a context, Network.Delete takes a single id and returns only an error, the image JSON namespace comes from core.ImageJSONNamespace.
Style and docs: comment budget applied, one-line comments, docs/networking.md and the clone help describe the inheritance.
Gates: GOWORK=off make lint (0 issues on linux and darwin), make fmt-check, asl ./... on both GOOS, go test -race -count=1 ./... (all ok), go build on GOOS=linux and darwin.