restore: carry a VNC password into the relaunch; drop the one-implementation Actions interfaces - #38
Merged
Conversation
cmd/vm and cmd/image each declared an Actions interface with a single Handler behind it and a compile-time assertion to match; Command takes the Handler.
A running VM whose display is password-gated could only be restored by stopping it first, since the password is never persisted. restore now takes --vnc-password like start does and hands it to the relaunch; a password-gated display without the flag is still refused before any disk is touched. docs/snapshots.md states the rule and the window for VMs launched before the password-set bit existed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits.
cmd/vmandcmd/imageeach declared anActionsinterface with a singleHandlerbehind it and a compile-time assertion to match (audit cut CM-A1);Commandtakes theHandler.vm restorenow takes--vnc-passwordlikestartdoes and hands it to the relaunch; a password-gated display without the flag is still refused before any disk is touched.docs/snapshots.mdstates the rule and the one remaining window: VMs launched by an older cocoon-macos with a passworded non-CNI display are not recognised as password-gated until their next stop or start.Gates:
make lint0 issues both GOOS,make fmt-check,asl ./...both GOOS,go test -race ./...; the Linux-gated lifecycle tests (including the refusal test) run on the Linux host: PASS.