Skip to content

refactor: introduce THEMES env var#4642

Draft
mxschll wants to merge 3 commits into
mainfrom
dev-v3-schomax-theming
Draft

refactor: introduce THEMES env var#4642
mxschll wants to merge 3 commits into
mainfrom
dev-v3-schomax-theming

Conversation

@mxschll

@mxschll mxschll commented Jun 17, 2026

Copy link
Copy Markdown
Member

Description

Allows dynamic inclusion of themes using THEMES=visual-refresh,one-theme npm run build. This will populate INCLUDED_THEMES which we then can use in dev pages. Introduces theme= url param.

Note: We can remove the visualRefresh=true param in as a next step.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxschll mxschll changed the title refactor: introduce INCLUDED_THEMES env var refactor: introduce THEMES env var Jun 17, 2026
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.52%. Comparing base (82d11d6) to head (07e5084).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4642   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         948      948           
  Lines       30363    30363           
  Branches    11077    11077           
=======================================
  Hits        29610    29610           
  Misses        706      706           
  Partials       47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant