feat(heureka): migrate ESLint config to vite-react-ts.mjs by hodanoori · Pull Request #1883 · cloudoperators/juno

hodanoori · 2026-08-11T13:48:42Z

Summary

Migrates the Heureka application from the legacy juno-typescript.mjs ESLint config to the new vite-react-ts.mjs configuration. The new config provides pure TypeScript linting rules without JavaScript rule interference, enabling strict type checking across the app. All 18+ legacy workaround rule overrides have been removed and replaced with real fixes. Part of the project-wide ESLint migration epic #1565.

Changes Made

Switch eslint.config.mjs to import vite-react-ts.mjs and remove all legacy rule workarounds
Add void operator to all fire-and-forget navigate() calls to satisfy no-floating-promises
Wrap async onClick handlers with void to fix no-misused-promises
Remove async from test loaders and act() callbacks that had no await (require-await); restore await act(async () => {...}) with a scoped disable for two Suspense-dependent tests where the async is required for React promise resolution
Replace issuesPromise && (...) with issuesPromise != null && (...) to fix no-misused-promises in boolean conditionals
Type queryClient.setQueriesData cache callbacks with a local cache shape type instead of any
Type getActiveVulnerabilityFilter and sanitizeFilterSettings with concrete types instead of any
Cast DateTime GraphQL scalar fields explicitly to fix no-unsafe-assignment
Fix getNormalizedError network error shape with an explicit type instead of any cast
Remove redundant string | "" union types in ComponentInstance (no-redundant-type-constituents)
Remove unnecessary as X type assertions in route validateSearch functions
Fix @ts-ignore → removed entirely in codegen.ts (dotenv has types)
Add /* eslint-disable */ header to auto-generated graphql.ts
Replace any in types/index.d.ts plugin options with Record<string, unknown>
Replace any in utils.ts utility functions (isEmpty, isNil, omit) with unknown
Fix ErrorBoundary resetKeys prop type from any to unknown[] and remove redundant !! cast
Add explicit React.MouseEvent / React.ChangeEvent / Date[] types to event handler callbacks where juno-ui-components prop types resolve as any in CI but correctly locally
Add scoped eslint-disable comments for useAuth() from greenhouse-auth-provider and encodeV2/decodeV2 from juno-url-state-provider — these packages export error-typed values in CI due to type resolution differences; each disable has an explanatory comment
Apply lint fixes to the new RemediationModal component introduced by a concurrent main branch refactor (same patterns: useAuth() cast, void handleConfirm(), typed input callbacks)
Add 2 justified rule overrides in eslint.config.mjs: react-refresh/only-export-components (TanStack Router requires mixed exports in route files) and react-hooks/set-state-in-effect (intentional derived-state sync pattern)
Set reportUnusedDisableDirectives: "off" to suppress false-positive warnings for CI-only disables that are unused locally (where package types resolve correctly)
Exclude vite.config.ts, vitest.config.ts, vitest.setup.ts, and tailwind.config.ts from ESLint entirely (not included in tsconfig.json, causing parse errors in type-aware linting)

Review Guide

Changes are mechanical and fall into 6 categories — reviewers can approve categories 2–5 at a glance and focus attention on 1 and 6:

Config & setup (eslint.config.mjs, package.json, vite-react-ts.mjs) — the actual migration; the only part worth careful review
void navigate(...) (~10 files) — fire-and-forget navigate() calls marked void; no behaviour change
async removal (~8 test files) — loader: async () => → loader: () => and act(async → act( where there was no await; no behaviour change. Two Suspense tests keep await act(async () => {...}) with a scoped lint disable.
Promise boolean guards (ImageIssuesList, ImageVersionIssuesList) — {promise && ...} → {promise != null && ...}; no behaviour change
Type tightening (utils.ts ×2, ErrorBoundary, getTestRouter, types/index.d.ts, event handler annotations) — any replaced with concrete types or explicit casts with comments
Typed cache callbacks (IssuesDataRow, RemediatedIssueDataRow, RemediationHistoryPanel, RemediationModal) — queryClient.setQueriesData callbacks now use a local RemediationsCache type instead of any; verify the shape matches what's actually stored in the cache

Related Issues

Issue 1: closes [Task](Heureka): Migrate to new Vite-React-TypeScript ESLint configuration #1720

Screenshots (if applicable)

none

Testing Instructions

pnpm i
pnpm TASK

Checklist

I have performed a self-review of my code.
I have commented my code, particularly in hard-to-understand areas.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.
I have made corresponding changes to the documentation (if applicable).
My changes generate no new warnings or errors.
I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Switches from juno-typescript.mjs to vite-react-ts.mjs, removing all 18+ legacy rule workarounds and fixing every violation surfaced by the stricter TypeScript-only config. Signed-off-by: Hoda Noori <hoda.noori@sap.com>

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

changeset-bot · 2026-08-11T13:48:46Z

🦋 Changeset detected

Latest commit: d8cc78b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@cloudoperators/juno-app-heureka	Patch
@cloudoperators/juno-app-greenhouse	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull request overview

Migrates the Heureka app to the new shared vite-react-ts.mjs ESLint flat-config and updates the app codebase to satisfy stricter type-aware TypeScript lint rules introduced by the migration.

Changes:

Switch apps/heureka/eslint.config.mjs to use @cloudoperators/juno-config/eslint/vite-react-ts.mjs and replace legacy rule workarounds with targeted, justified overrides.
Apply mechanical lint fixes across the app (e.g., void navigate(...), remove unnecessary async, tighten types / remove any, adjust promise guards).
Update Heureka devDependencies/lockfile and add a changeset documenting the migration.

Reviewed changes

Copilot reviewed 41 out of 44 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Locks new ESLint-related dependencies needed for the new config/migration.
packages/config/eslint/vite-react-ts.mjs	Introduces/adjusts the shared Vite React TS ESLint flat-config used by apps.
apps/heureka/src/utils.ts	Tightens utility typings (`any` → `unknown`) to satisfy stricter TS lint rules.
apps/heureka/src/types/index.d.ts	Replaces `Record<string, any>` with `Record<string, unknown>` for plugin options.
apps/heureka/src/routes/vulnerabilities/index.tsx	Removes unnecessary type assertion and `async` loader where no `await` is used.
apps/heureka/src/routes/services/index.tsx	Removes unnecessary type assertion and marks `navigate()` as fire-and-forget with `void`.
apps/heureka/src/mocks/getTestRouter.tsx	Adjusts test router helper typing/imports to satisfy linting constraints.
apps/heureka/src/generated/graphql.ts	Marks generated file and disables linting for it.
apps/heureka/src/components/Vulnerabilities/VulnerabilitiesList/VulnerabilityDetailsPanel/VulnerabilityServices.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/Vulnerabilities/VulnerabilitiesList/VulnerabilityDetailsPanel/index.tsx	Adds `void` to navigations and removes redundant boolean cast in `heading`.
apps/heureka/src/components/Vulnerabilities/VulnerabilitiesList/VulnerabilitiesDataRows/index.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/Vulnerabilities/VulnerabilitiesList/index.test.tsx	Removes unnecessary `async` loader in tests.
apps/heureka/src/components/Vulnerabilities/VulnerabilitiesFilters.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/Vulnerabilities/Vulnerabilities.test.tsx	Removes unnecessary `async` loader/`act(async ...)` usage.
apps/heureka/src/components/Vulnerabilities/utils.ts	Replaces `any` with concrete types; adds explicit DateTime scalar casting and safer cache shape typing.
apps/heureka/src/components/Services/utils.ts	Tightens error typing and removes redundant type constituents / `any` usage.
apps/heureka/src/components/Services/ServicesList/ServicesDataRows/index.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/Services/ServicesList/ServicePanel.tsx	Adds `void` to fire-and-forget navigation and removes redundant boolean cast in `heading`.
apps/heureka/src/components/Services/ServicesList/ServicePanel.test.tsx	Removes unnecessary `async` loader in tests.
apps/heureka/src/components/Services/ServicesList/index.test.tsx	Removes unnecessary `async` loader in tests.
apps/heureka/src/components/Services/ServicesFilters.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/Services/Services.test.tsx	Removes unnecessary `async` loader/`act(async ...)` usage.
apps/heureka/src/components/Service/index.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/Service/ImageVersionDetails/ImageVersionIssuesList/index.tsx	Fixes promise guard in JSX (`promise != null && ...`).
apps/heureka/src/components/Service/ImageDetails/RiskAcceptanceModal/RiskAcceptanceModal.test.tsx	Tightens mocked component typings and removes unnecessary async test wrapper.
apps/heureka/src/components/Service/ImageDetails/RiskAcceptanceModal/index.tsx	Wraps async click handler; adjusts auth typing to satisfy lint rules.
apps/heureka/src/components/Service/ImageDetails/index.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/Service/ImageDetails/ImageVersionsList/index.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/Service/ImageDetails/ImageIssuesList/RemediationHistoryPanel/RemediationHistoryPanel.test.tsx	Replaces `any` promise typing with explicit result shape.
apps/heureka/src/components/Service/ImageDetails/ImageIssuesList/RemediationHistoryPanel/index.tsx	Tightens query key/cache typing and wraps async click handler with `void`.
apps/heureka/src/components/Service/ImageDetails/ImageIssuesList/RemediatedIssuesDataRows/RemediatedIssuesDataRows.test.tsx	Removes unnecessary `async` `act(...)` usage.
apps/heureka/src/components/Service/ImageDetails/ImageIssuesList/RemediatedIssuesDataRows/RemediatedIssueDataRow/index.tsx	Adds typed cache shapes for `setQueriesData` and removes `any` usage.
apps/heureka/src/components/Service/ImageDetails/ImageIssuesList/IssuesDataRows/IssuesDataRows.test.tsx	Updates test `act(...)` usage and related lint-driven changes.
apps/heureka/src/components/Service/ImageDetails/ImageIssuesList/IssuesDataRows/IssuesDataRow/index.tsx	Adds typed cache shapes for `setQueriesData` and removes `any` usage.
apps/heureka/src/components/Service/ImageDetails/ImageIssuesList/index.tsx	Fixes promise guards in JSX and adds `void` to fire-and-forget navigations.
apps/heureka/src/components/Service/ImageDetails/FalsePositiveModal/index.tsx	Wraps async click handler; adjusts auth typing to satisfy lint rules.
apps/heureka/src/components/common/Navigation.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/src/components/common/ErrorBoundary/index.tsx	Tightens `resetKeys` type (`any` → `unknown[]`) and removes redundant boolean cast.
apps/heureka/src/components/common/ErrorBoundary/index.test.tsx	Tightens spy typing and adds lint suppression for mockRestore call.
apps/heureka/src/components/common/Breadcrumb.tsx	Adds `void` to fire-and-forget navigation.
apps/heureka/package.json	Adds ESLint-related devDependencies required by the new config.
apps/heureka/eslint.config.mjs	Switches to shared `vite-react-ts.mjs` config; replaces legacy overrides with 2 justified ones.
apps/heureka/codegen.ts	Removes unnecessary `@ts-ignore` (dotenv has types).
.changeset/heureka-eslint-vite-react-ts-migration.md	Adds changeset entry documenting the ESLint config migration.

Files not reviewed (1)

pnpm-lock.yaml: Generated file

Suppressed comments (1)

packages/config/eslint/vite-react-ts.mjs:29

This config still extends @eslint/js's recommended rules, which reintroduces JavaScript rule sets into what is described (in the PR/epic) as a “pure TypeScript” ESLint config. If the goal is to avoid JS/TS rule mixing, drop the JS recommended config here and rely on the TypeScript-ESLint presets instead.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

- Fix inaccurate comment in eslint.config.mjs: ignores excludes files entirely, not just from type-aware linting - Fix bug: act() with sync callback returns void, not the render result; capture unmount from renderWithRouter() directly Signed-off-by: Hoda Noori <hoda.noori@sap.com>

…nces - Add explicit React.MouseEvent types to event handlers (stopPropagation, preventDefault) where juno-ui-components prop types resolve as any in CI - Add explicit ChangeEvent/Date[] types to RemediationModal input handlers - Add explicit string|undefined type to onSearch callbacks - Add eslint-disable comments for greenhouse-auth-provider and juno-url-state-provider types that are error-typed in CI (EmbeddedAuth, AuthState, encodeV2, decodeV2) - Add eslint-disable to vi.mock importActual calls in test files - Add eslint-disable to getSeverityColor/getSeverityIcon assignments - Set reportUnusedDisableDirectives: off to suppress unused-directive warnings for CI-only disables Signed-off-by: Hoda Noori <hoda.noori@sap.com>

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

…ons error type in CI Signed-off-by: Hoda Noori <hoda.noori@sap.com>

…rors Signed-off-by: Hoda Noori <hoda.noori@sap.com>

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

Copilot

Pull request overview

Copilot reviewed 47 out of 50 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

pnpm-lock.yaml: Generated file

taymoor89

Overall looks good to me!
I'm a little concerned about adding void to every navigate call, since our intention is simply to trigger the navigation without waiting for the promise to resolve. That said, I think we can live with it, as the rule provides more value than the minor inconvenience this introduces.

taymoor89

Let's address AI suggestions, some of these are good to address

- Extract QueryFilter/RemediationsCache to shared remediationCacheTypes.ts and reuse across IssuesDataRow, RemediatedIssueDataRow, RemediationHistoryPanel - Add explanatory comments to file-level eslint-disable in IssueIcon, SeverityCount, VulnerabilityDataRow (CI-only type resolution issue) - Add eslint-disable with comment for refreshKey in RemediationHistoryPanel useMemo (intentional trigger dependency, not a data dependency) - Fix useCallback missing deps: add setVulnerabilitiesSuccessMessage and setRemediatedSuccessMessage to dependency arrays in ImageIssuesList - Align postcss version in package.json to 8.5.23 to match lockfile Signed-off-by: Hoda Noori <hoda.noori@sap.com>

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

hodanoori · 2026-08-14T09:26:08Z

Overall looks good to me!
I'm a little concerned about adding void to every navigate call, since our intention is simply to trigger the navigation without waiting for the promise to resolve. That said, I think we can live with it, as the rule provides more value than the minor inconvenience this introduces.

The void is purely there to satisfy the no-floating-promises rule, not to change behavior. The navigation still fires synchronously and we don't await it. One alternative would be to wrap navigate in a helper that returns void explicitly, but that adds indirection for little gain. Happy to keep it as-is if you're fine with it. Thanks for the review

hodanoori added 3 commits August 11, 2026 15:40

feat(heureka): migrate ESLint config to vite-react-ts.mjs

a0af8d9

Switches from juno-typescript.mjs to vite-react-ts.mjs, removing all 18+ legacy rule workarounds and fixing every violation surfaced by the stricter TypeScript-only config. Signed-off-by: Hoda Noori <hoda.noori@sap.com>

chore(heureka): apply Prettier formatting to migration changes

7511e24

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

chore(heureka): apply Prettier formatting to modal files

a93f59e

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

Copilot AI lite review requested due to automatic review settings August 11, 2026 13:48

hodanoori requested a review from a team as a code owner August 11, 2026 13:48

hodanoori self-assigned this Aug 11, 2026

Copilot started reviewing on behalf of hodanoori August 11, 2026 13:49 View session

Copilot AI reviewed Aug 11, 2026

View reviewed changes

hodanoori and others added 9 commits August 11, 2026 15:59

chore(heureka): merge main and resolve conflicts

3af7f9c

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

chore(heureka): apply Prettier formatting after merge

a12f9b7

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

fix(heureka): use inline eslint-disable for CI-only type errors

db502a6

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

Merge branch 'main' into hoda-heureka-update-vite-react-type-script

bef1b9f

fix(heureka): type iconMap as Record<string, string> to avoid KnownIc…

34e50f1

…ons error type in CI Signed-off-by: Hoda Noori <hoda.noori@sap.com>

fix(heureka): add file-level eslint-disable for KnownIcons CI type er…

3ea5287

…rors Signed-off-by: Hoda Noori <hoda.noori@sap.com>

fix(heureka): restore await act(async) for Suspense-dependent tests

5ed0dc1

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

hodanoori added the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label Aug 12, 2026

github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Aug 12, 2026

TilmanHaupt reviewed Aug 13, 2026

View reviewed changes

Comment thread apps/heureka/src/components/common/SeverityCount.tsx

TilmanHaupt reviewed Aug 13, 2026

View reviewed changes

TilmanHaupt requested a lite review from Copilot August 13, 2026 09:56

Copilot started reviewing on behalf of TilmanHaupt August 13, 2026 09:57 View session

Copilot AI reviewed Aug 13, 2026

View reviewed changes

Comment thread apps/heureka/package.json

Comment thread pnpm-lock.yaml

taymoor89 previously approved these changes Aug 13, 2026

View reviewed changes

taymoor89 reviewed Aug 13, 2026

View reviewed changes

hodanoori dismissed taymoor89’s stale review via 72622c3 August 14, 2026 08:17

github-actions Bot removed the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Aug 14, 2026

github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Aug 14, 2026

chore(heureka): apply Prettier 3.8.5 formatting to ImageIssuesList

d8cc78b

Signed-off-by: Hoda Noori <hoda.noori@sap.com>

github-actions Bot added greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. and removed greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. labels Aug 14, 2026

TilmanHaupt approved these changes Aug 14, 2026

View reviewed changes

Navigation Menu

Uh oh!

feat(heureka): migrate ESLint config to vite-react-ts.mjs - #1883

feat(heureka): migrate ESLint config to vite-react-ts.mjs#1883
hodanoori wants to merge 14 commits into
mainfrom
hoda-heureka-update-vite-react-type-script

hodanoori commented Aug 11, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Aug 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

taymoor89 left a comment •

edited

Loading

Uh oh!

taymoor89 left a comment

Uh oh!

hodanoori commented Aug 14, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

hodanoori commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Review Guide

Related Issues

Screenshots (if applicable)

Testing Instructions

Checklist

PR Manifesto

Uh oh!

changeset-bot Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

taymoor89 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taymoor89 left a comment

Choose a reason for hiding this comment

Uh oh!

hodanoori commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hodanoori commented Aug 11, 2026 •

edited

Loading

changeset-bot Bot commented Aug 11, 2026 •

edited

Loading

taymoor89 left a comment •

edited

Loading

hodanoori commented Aug 14, 2026 •

edited

Loading