fix(walrestore): use timeline-aware barman-cloud end-of-WAL markers#11133
Open
ardentperf wants to merge 5 commits into
Open
fix(walrestore): use timeline-aware barman-cloud end-of-WAL markers#11133ardentperf wants to merge 5 commits into
ardentperf wants to merge 5 commits into
Conversation
dosubot
Bot
added
the
size:M
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Contributor
|
Warning Linked issue missing. Reference one in the PR body using a keyword (Closes / Fixes / Resolves / Refs / See) followed by Alternatively, apply the |
Contributor
|
👍 LGTM. This looks safe to me and could fix a lot of issues 🤔 . |
armru
approved these changes
Jul 8, 2026
Member
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/28954401725 |
Member
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/29002285379 |
Member
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/29005484149 |
Update in-tree `wal-restore` to use the new `barman-cloud` restorer APIs, resolving a bug that can cause replicas to enter a broken state that CNPG cant recover from. Local marker naming, WAL timeline parsing, and restore-result filtering policy now lives in `github.com/cloudnative-pg/barman-cloud/pkg/restorer`. depends on cloudnative-pg/barman-cloud#277 Signed-off-by: Jeremy Schneider <schneider@ardentperf.com>
…e-pg#277 Point barman-cloud at the fork branch behind cloudnative-pg/barman-cloud#277 so this PR builds and CI can run, and allow the replace directive in the linter configuration. Both changes must be reverted in favor of an upstream barman-cloud release when merging. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
The tests directory is a separate Go module, and replace directives are only honored from the main module, so the fork replace in the root go.mod does not apply when the e2e suite compiles the operator packages. Mirror it in tests/go.mod so vet and the e2e build resolve the barman-cloud fork too. To be reverted together with the root replace once cloudnative-pg/barman-cloud#277 is merged and released. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
The fork branch is based on barman-cloud main, which adds the restoreAdditionalCommandArgs field to the barman object store API that is not part of the released v0.5.1, so the generated Cluster CRD gains that field. The change is purely additive and stays valid once the dependency moves to the next upstream barman-cloud release. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Member
|
Hello @ardentperf I tried to run e2e test suite but I see consistent failing for
|
…g#277 Point the fork replace at 1953fc7, the original commit proposed in cloudnative-pg/barman-cloud#277, instead of the branch head that also carries a follow-up refactor. This keeps the end-to-end investigation running against the unmodified original change. The generated CRDs are unaffected since the follow-up only touched the restorer internals. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Member
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/29016380587 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A global end-of-WAL marker can be set by a parent-timeline prefetch miss and then consumed by a child-timeline restore request. In snapshot-restored replica flows, that can cause PostgreSQL to miss valid child-timeline WAL and replay wrong parent-timeline bytes. Reference cloudnative-pg/barman-cloud#276
Update in-tree
wal-restoreto use the newbarman-cloudrestorer APIs:ConsumeEndOfWALStreamForWALSetEndOfWALStreamFromResultsDepends on cloudnative-pg/barman-cloud#277