Accept span completion after request teardown - #7016
Open
apeacock1991 wants to merge 2 commits into
Open
Conversation
Contributor
|
APIError: Invalid Anthropic API Key |
2 similar comments
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
APIError: Invalid Anthropic API Key |
Contributor
|
@apeacock1991 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
apeacock1991
force-pushed
the
apeacock/fix-span-without-current-request
branch
from
August 16, 2026 12:19
11daa68 to
b35ee73
Compare
Revert the workerd side of #7018, restoring per-call JSRPC spans and trace continuity.
apeacock1991
force-pushed
the
apeacock/fix-span-without-current-request
branch
from
August 16, 2026 12:24
b35ee73 to
e4db9fb
Compare
IoContext tasks may close spans after their IncomingRequest is destroyed. The tracer already records the request completion time for this case, but still emitted a warning and Sentry alert. Use the recorded timestamp without warning when it is available. Keep the warning when neither a current request nor completion time exists, and cover request teardown and replacement-request timing.
apeacock1991
force-pushed
the
apeacock/fix-span-without-current-request
branch
from
August 17, 2026 11:04
e4db9fb to
f8a0449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IoContext tasks may close spans after their IncomingRequest is destroyed. The tracer already records the request completion time for this case, but still emitted a warning and Sentry alert.
Use the recorded timestamp without warning when it is available. Keep the warning when neither a current request nor completion time exists, and cover request teardown and replacement-request timing.