STOR-5542: Alarms no longer retry when calling ctx.abort() via new compat flag - #6996
STOR-5542: Alarms no longer retry when calling ctx.abort() via new compat flag#6996apeacock1991 wants to merge 1 commit into
Conversation
|
APIError: Invalid Anthropic API Key |
2 similar comments
|
APIError: Invalid Anthropic API Key |
|
APIError: Invalid Anthropic API Key |
|
@apeacock1991 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
03f2449 to
43ddb05
Compare
apeacock1991
changed the title
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
Approving from a typings point of view
43ddb05 to
6e9d369
Compare
|
The generated output of |
| KJ_EXPECT(scheduler.getAlarm(actor) == kj::none); | ||
| } | ||
|
|
||
| KJ_TEST("AlarmScheduler preserves an alarm queued while abandonment is pending") { |
There was a problem hiding this comment.
This was technically a pre-existing race (in the case of alarm exhaustion), but worth closing the gap in this PR
6e9d369 to
e4d305f
Compare
apeacock1991
changed the title
Add an ABORTED event outcome and propagate whether an alarm abort should retry through the runtime layers. Gate terminal alarm abandonment on a dated compatibility flag. Preserve replacement alarms queued while asynchronous cleanup is in progress.
e4d305f to
6439f28
Compare
2 participants
Add a compatibility flag that does not retry alarms that are aborted.
Preserve the signal through both handler and output-gate error paths, with the latter being able to potentially override the abort signal and trigger a retry.