[Wallets] Add Cloudflare Wallets handle reservation docs - #32568
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://0c047066.preview.developers.cloudflare.com Files with changes (up to 15) |
f79ce33 to
1713117
Compare
WillPapper
left a comment
There was a problem hiding this comment.
LGTM! (I authored the Wallets blog post at https://blog.cloudflare.com/wallets/)
|
the where can I report abuse/spam question feels like it could be more targeted, but otherwise lgtm (I work with the author of the Wallets blog post at https://blog.cloudflare.com/wallets/) "Where can I report trademark infringements, abuse or spam" |
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32568 (https://github.com/cloudflare/cloudflare-docs/pull/32568).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-4a274e7ec213 · Incorrect CODEOWNERS section placement
- **File:** `.github/CODEOWNERS` line 37
- **Issue:** The new `/src/content/docs/wallets/` rule is inserted under the `# AI` section, between Vectorize and AI Search entries, but Wallets is not an AI product.
- **Fix:** Move the Wallets ownership rule out of the `# AI` section, e.g. to a new `# Wallets` section or another appropriate product grouping.
### Suggestions (1)
#### CR-5119356b1c5c · Unused component import
- **File:** `src/content/docs/wallets/index.mdx` line 20
- **Issue:** `LinkButton` is imported in the MDX import block but is never used anywhere in the file.
- **Fix:** Remove the unused `LinkButton` import to keep the import list clean and avoid shipping dead code.
---
## Conventions
### Warnings (2)
#### CV-792b2e852327 · Scope accuracy
- **File:** PR-level finding
- **Issue:** The description claims five pages under /cloudflare-wallets/ are added, but only src/content/docs/wallets/index.mdx and src/content/docs/wallets/faq.mdx appear in the change set; wallet-handles.mdx, reserve-a-wallet-handle.mdx, and wallet-handle-requirements.mdx are absent. The PR also modifies WAF changelog files, a Workers AI changelog file, Workers AI pricing, and Workers AI model files, none of which are mentioned in the description.
- **Fix:** Update the description to accurately reflect which wallet pages are actually added and to account for the WAF and Workers AI changes, or remove unrelated changes from the PR.
#### CV-bc67e227862a · Product or area identified
- **File:** PR-level finding
- **Issue:** Title "[Wallets] Add Cloudflare Wallets handle reservation docs" names only Wallets, but the changed files also cover WAF and Workers AI products.
- **Fix:** Update the title to include the additional affected products or split the unrelated changes into separate PRs.
---
## Style Guide Review
### Suggestions (1)
#### SG-1f42073de123 · Use consistent product name
- **File:** `src/content/docs/wallets/faq.mdx` line 14
- **Issue:** The frontmatter `head` title and description use "Cloudflare Wallets" (plural), but the body repeatedly uses "Cloudflare Wallet handle(s)" (singular "Wallet").
- **Fix:** Use the same product name form throughout the page, likely "Cloudflare Wallets" to match the frontmatter and PR title.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
Suggestions (1)
Conventions❌ This review could not complete this run; results may be incomplete. It will retry on the next push. Warnings (2)
Style Guide ReviewSuggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
bc0ccba to
c1ec0b9
Compare
Documents the wallet handle reservation flow at cloudflare.pay, which launched via the Cloudflare Wallets announcement but has no docs coverage. Covers how handles are allocated and why reservations are final, the format and reserved name rules, how to confirm the reservation site is genuine, and the trademark reporting route.
642dbcf to
0c04706
Compare
Summary
New product section documenting the Cloudflare Wallets handle reservation flow at
cloudflare.pay, announced in Announcing Cloudflare Wallets. The blog post is currently the only public source, so nothing published covers how reservations work.Reviewed with the Agent Payments team. The policy below has been corrected from the first draft: reservations are not final, and Cloudflare reserves the right to reject or reclaim one. Still holding as draft pending the rest of that review.
Five pages under
/cloudflare-wallets/:index.mdxwallet-handles.mdxreserve-a-wallet-handle.mdxcloudflare.payis genuinewallet-handle-requirements.mdxfaq.mdxBehaviour and policy documented:
cloudflare.payis a genuine Cloudflare domain. Sign-in happens ondash.cloudflare.com, and the application requests read-only access.Also adds the
cloudflare-walletsdirectory entry and a landing nav link under Build > AI.Documentation checklist