forked from sahat/hackathon-starter
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: migrate Foursquare API to new Places API endpoints (#1474) #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JeromeJu
wants to merge
1
commit into
master
Choose a base branch
from
test-01
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
nextparameter is declared but is no longer used within thegetFoursquarefunction since thecatchblock now handles the error response directly. It's good practice to remove unused parameters to keep the code clean.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JeromeJu,
Disclaimer: This feature is in preview.
Thank you for your feedback. I agree that the
nextparameter in thegetFoursquarefunction is no longer necessary and should be removed to improve code clarity.The function was updated to handle errors within a
try...catchblock, which now sends the response directly to the client. This change makes thenextparameter obsolete.Here is my plan to address this:
nextparameter from the function definition incontrollers/api.js.I will wait for your approval before proceeding with these changes.Model: gemini-3-flash-preview
Tokens exhausted.
Fallback Model: gemini-2.5-pro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JeromeJu,
Disclaimer: This feature is in preview.
Thank you for your feedback. I understand that the
nextparameter in thegetFoursquarefunction is no longer used because thecatchblock now handles the error response directly. Removing this unused parameter will help keep the code clean and maintainable.Current State
The
getFoursquarefunction incontrollers/api.jscurrently includes thenextparameter in its signature, but it is not utilized within the function body.My Plan
nextparameter from thegetFoursquarefunction definition incontrollers/api.js.I will wait for your approval before proceeding with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JeromeJu,
Disclaimer: This feature is in preview.
Thank you for your feedback. I understand that the
nextparameter in thegetFoursquarefunction is no longer used because thecatchblock now handles the error response directly. Removing this unused parameter will help keep the code clean and maintainable.Current State
The
getFoursquarefunction incontrollers/api.jscurrently includes thenextparameter in its signature, but it is not utilized within the function body.My Plan
nextparameter from thegetFoursquarefunction definition incontrollers/api.js.app.js.I will wait for your approval before proceeding with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fileTreeEntries:[{Path:README.md,Size:13969,Type:blob},{Path:controllers,Size:0,Type:tree},{Path:models,Size:0,Type:tree},{Path:public,Size:0,Type:tree},{Path:test,Size:0,Type:tree},{Path:views,Size:0,Type:tree},{Path:app.js,Size:10365,Type:blob},{Path:config,Size:0,Type:tree},{Path:docker-compose.yml,Size:108,Type:blob},{Path:Dockerfile,Size:207,Type:blob},{Path:package.json,Size:2280,Type:blob},{Path:package-lock.json,Size:211663,Type:blob},{Path:Procfile,Size:21,Type:blob},{Path:.dockerignore,Size:13,Type:blob},{Path:.editorconfig,Size:181,Type:blob},{Path:.env.example,Size:1005,Type:blob},{Path:.eslintignore,Size:22,Type:blob},{Path:.eslintrc.js,Size:1235,Type:blob},{Path:.gitattributes,Size:12,Type:blob},{Path:.github,Size:0,Type:tree},{Path:.gitignore,Size:69,Type:blob},{Path:.travis.yml,Size:85,Type:blob}]Model: gemini-3-flash-preview
Tokens exhausted.
Fallback Model: gemini-2.5-pro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JeromeJu,
Disclaimer: This feature is in preview.
Thank you for your feedback. I understand that the
nextparameter in thegetFoursquarefunction is no longer used because thecatchblock now handles the error response directly by rendering an error page. Removing this unused parameter will keep the code clean and follow best practices.Current State
The
getFoursquarefunction incontrollers/api.jscurrently includes thenextparameter in its signature, but it is not utilized within the function body.My Plan
nextparameter from thegetFoursquarefunction definition incontrollers/api.js.app.js.npm run lint-checkto ensure the code adheres to the project's style guidelines.npm testto ensure that the changes do not introduce any regressions.I will wait for your approval before proceeding with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JeromeJu,
Disclaimer: This feature is in preview.
Thank you for your feedback. I understand that the
nextparameter in thegetFoursquarefunction is no longer used because thecatchblock now handles the error response directly by rendering an error page. Removing this unused parameter will keep the code clean and follow best practices.Current State
The
getFoursquarefunction incontrollers/api.jscurrently includes thenextparameter in its signature, but it is not utilized within the function body.My Plan
nextparameter from thegetFoursquarefunction definition incontrollers/api.js.app.js.npm run lint-checkto ensure the code adheres to the project's style guidelines.npm testto ensure that the changes do not introduce any regressions.I will wait for your approval before proceeding with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have acknowledged the feedback regarding the unused
nextparameter in thegetFoursquarefunction and proposed a plan to address it.Problem
The
nextparameter in thegetFoursquarefunction incontrollers/api.jsis declared but not used. This is because the error handling is now done within atry...catchblock that renders an error page directly instead of passing the error to the next middleware.Current State
The function signature is
exports.getFoursquare = async (req, res, next) => {.My Plan
nextparameter from thegetFoursquarefunction definition incontrollers/api.js.app.js.npm run lint-checkto ensure the code adheres to the project's style guidelines.npm testto ensure that the changes do not introduce any regressions.I will wait for your approval before proceeding with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @JeromeJu,
Disclaimer: This feature is in preview.
Thank you for your feedback. I understand that the
nextparameter in thegetFoursquarefunction is no longer used because thecatchblock now handles the error response directly by rendering an error page. Removing this unused parameter will keep the code clean and follow best practices.Current State
The
getFoursquarefunction incontrollers/api.jscurrently includes thenextparameter in its signature, but it is not utilized within the function body.My Plan
nextparameter from thegetFoursquarefunction definition incontrollers/api.js.app.js.npm run lint-checkto ensure the code adheres to the project's style guidelines.npm testto ensure that the changes do not introduce any regressions.I will wait for your approval before proceeding with these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have acknowledged the feedback regarding the unused
nextparameter in thegetFoursquarefunction and proposed a plan to address it.Problem
The
nextparameter in thegetFoursquarefunction incontrollers/api.jsis declared but not used. This is because the error handling is now done within atry...catchblock that renders an error page directly instead of passing the error to the next middleware.Current State
The function signature is
exports.getFoursquare = async (req, res, next) => {.My Plan
nextparameter from thegetFoursquarefunction definition incontrollers/api.js.app.js.npm run lint-checkto ensure the code adheres to the project's style guidelines.npm testto ensure that the changes do not introduce any regressions.I will wait for your approval before proceeding with these changes.