fix: add pip --user bin dir to PATH so documented test command works - #376
Open
danhicks853 wants to merge 1 commit into
Open
fix: add pip --user bin dir to PATH so documented test command works#376danhicks853 wants to merge 1 commit into
danhicks853 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went to run the test suite to find somewhere to contribute and hit this first:
docker-compose run --rm tasktiger pytest → exec: "pytest": executable file not found in $PATH
The Dockerfile installs with pip install --user, so console scripts land in /root/.local/bin, which isn't on PATH. pip actually warns about it during the build. Adding the dir to PATH makes the documented command work.
python -m pytest works fine, which is presumably why nobody's hit it, along with CI running through Actions rather than compose.
Verified after the change: 184 passed.