Skip to content

Replace zh_TW, zh_CN languages with zh_hans, zh_hant. Drop nb language. - #1442

Open
Mati365 wants to merge 17 commits into
masterfrom
ck/10480
Open

Replace zh_TW, zh_CN languages with zh_hans, zh_hant. Drop nb language.#1442
Mati365 wants to merge 17 commits into
masterfrom
ck/10480

Conversation

@Mati365

@Mati365 Mati365 commented Jul 21, 2026

Copy link
Copy Markdown
Member

🚀 Summary

Replace zh_TW, zh_CN languages with zh_hans, zh_hant. Drop nb language.


📌 Related issues

@Mati365
Mati365 marked this pull request as ready for review July 21, 2026 11:38
@Mati365
Mati365 requested a review from a team July 21, 2026 11:38
Comment thread packages/ckeditor5-dev-translations/tests/utils/getlanguages.js Outdated
Comment thread packages/ckeditor5-dev-translations/tests/utils/getlanguages.js Outdated
Comment thread packages/ckeditor5-dev-translations/tests/utils/getlanguages.js
Comment thread packages/ckeditor5-dev-translations/lib/utils/getlanguages.js Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e4ad808. Configure here.

Comment thread packages/ckeditor5-dev-translations/lib/utils/getlanguages.js

@przemyslaw-zan przemyslaw-zan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title is invalid. It's about the filename, not the "language code", and omits zh_CN → zh-hans and the nb removal. Suggested: Map zh_CN/zh_TW to zh-hans/zh-hant filenames and drop the nb locale.

Comment thread .changelog/20260721132553_ck_10480.md Outdated
Comment thread packages/ckeditor5-dev-translations/lib/utils/getlanguages.js
@Mati365 Mati365 changed the title No longer map zh_TW language to zh language code in dev translations. Replace zh_TW, zh_CN languages with zh_hans, zh_hant. Drop nb language. Jul 28, 2026
@Mati365
Mati365 requested a review from przemyslaw-zan July 28, 2026 07:57
Comment thread .changelog/20260728081737_ck_10480.md Outdated
@Mati365
Mati365 requested a review from przemyslaw-zan July 28, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants