Conversation
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* test: add legacy-data upgrade-path integration test to CI Simulate a user upgrading offckb: an old release (0.3.4, CKB 0.113.1) creates a devnet in a sandboxed HOME/XDG, then the current build must operate on that legacy data without breaking it: - the chain continues (same genesis hash, tip grows past the old tip), so a silent chain reset cannot pass as 'RPC responds' - the legacy ckb.toml is migrated (Terminal RPC module + tcp_listen_address) — the class of bug that previously reached users before we noticed - the bundled chain spec stays byte-identical - a fresh transfer succeeds and is committed Runs per-PR on ubuntu-latest only, after create-test; the npm cache is cached to keep the extra legacy CLI install cheap. Verified end-to-end locally twice (offckb 0.3.4 → 0.4.10). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci: run legacy-data test before create-test create-test.sh's cleanup kills only the pnpm wrapper, leaving the CKB processes orphaned and holding ports 8114/28114 (the runner's orphan cleanup only fires at job end), which tripped the legacy test's precondition check. Run the legacy test first instead — its own teardown is complete, so create-test still starts on free ports. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (5)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.